feat: improve filter subscriptions #2193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Comment on lines
12
to
+13
| export async function createLightNode( | ||
| options: CreateWakuNodeOptions = {} | ||
| options: ProtocolCreateOptions = {} |
There was a problem hiding this comment.
ProtocolCreateOptions used for a createNode argument -- perhaps change naming/functionality here?
| @@ -31,6 +26,9 @@ type MetadataService = { | |||
|
|
|||
| const log = new Logger("sdk:create"); | |||
|
|
|||
| const DefaultUserAgent = "js-waku"; | |||
There was a problem hiding this comment.
nit: we're using mostly SNAKE_CASE for constants
Comment on lines
+61
to
+68
| if (this.messageCache.has(pubsubTopic, wakuMessage as IProtoMessage)) { | ||
| log.info( | ||
| `Skipping duplicate message for pubsubTopic:${pubsubTopic} peerId:${peerIdStr}` | ||
| ); | ||
| return; | ||
| } | ||
|
|
||
| this.messageCache.set(pubsubTopic, wakuMessage as IProtoMessage); |
There was a problem hiding this comment.
nit: we can move this to a private function
| type Timestamp = number; | ||
|
|
||
| export class MessageCache { | ||
| private intervalID: number | undefined = undefined; |
There was a problem hiding this comment.
nit:
Suggested change
| private intervalID: number | undefined = undefined; | |
| private intervalId: number | undefined = undefined; |
Comment on lines
+71
to
+73
| log.info( | ||
| `requestRenew: Renewed peer ${peerId.toString()} to ${newPeer.id.toString()}` | ||
| ); |
There was a problem hiding this comment.
can we provide a potential reason of why this could've failed?
Possibly no peers available to renew with?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During debugging sessions our team had we determined points for improvement for
Filter/Subscriptionentities.It was clear that they can be improved with better handling of configuration and peer management.
Solution
This PR improves configuration handling and
PeerManageras well as adds timedMessageCache.Notes
This PR is second to #2191