Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve dependencies handling of @libp2p in pnpm #2200

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Jan 10, 2025

Problem

pnpm gets confused with peerDependencies js-waku has and misses @libp2p/bootstrap package.

Solution

This PR removes peerDependencies as they are making pnpm misbehave with how it resolves dependencies.
There is no problem with pnpm as I see, it's more of a problem with peerDeps getting out of sync with other deps while libp2p goes through upgrade.

Notes

@waku/sdk is published under 0.0.30-1c0c5ee.0 version with this fix.

As for peerDependencies - removing them to prevent any confusion. Let's add them back once requested by consumers.

Copy link

github-actions bot commented Jan 10, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 86.63 KB (0%) 1.8 s (0%) 7.9 s (-17.98% 🔽) 9.6 s
Waku Simple Light Node 137.06 KB (0%) 2.8 s (0%) 10 s (-18.87% 🔽) 12.7 s
ECIES encryption 22.88 KB (0%) 458 ms (0%) 3.4 s (-19.81% 🔽) 3.9 s
Symmetric encryption 22.37 KB (0%) 448 ms (0%) 3.5 s (-13.71% 🔽) 4 s
DNS discovery 70.54 KB (0%) 1.5 s (0%) 6.1 s (-37.83% 🔽) 7.5 s
Peer Exchange discovery 71.82 KB (0%) 1.5 s (0%) 6.7 s (-30.11% 🔽) 8.2 s
Local Peer Cache Discovery 65.17 KB (0%) 1.4 s (0%) 8.3 s (+6.03% 🔺) 9.6 s
Privacy preserving protocols 76.16 KB (0%) 1.6 s (0%) 10.6 s (+8.33% 🔺) 12.1 s
Waku Filter 80.98 KB (0%) 1.7 s (0%) 9.3 s (+2.68% 🔺) 11 s
Waku LightPush 75.72 KB (0%) 1.6 s (0%) 9.3 s (+15.78% 🔺) 10.8 s
History retrieval protocols 77.63 KB (0%) 1.6 s (0%) 10.1 s (+38.16% 🔺) 11.6 s
Deterministic Message Hashing 7.39 KB (0%) 148 ms (0%) 1.5 s (+7.71% 🔺) 1.6 s

@weboko weboko changed the title fix: improve dependencies to @libp2p fix: improve dependencies handling of @libp2p in pnpm Jan 10, 2025
@weboko weboko marked this pull request as ready for review January 10, 2025 10:41
@weboko weboko requested a review from a team as a code owner January 10, 2025 10:41
@danisharora099
Copy link
Collaborator

@weboko pulling from master should now resolve this PR's browser CI failure

@weboko weboko merged commit f34fc4b into master Jan 16, 2025
10 of 11 checks passed
@weboko weboko deleted the weboko/investigate-deps branch January 16, 2025 13:27
@weboko weboko mentioned this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: @libp2p/bootstrap and @libp2p/interface peer dependencies not correctly added
2 participants