Node-5583 Required variables for smoke-tests #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braek-neck
force-pushed
the
NODE-5583
branch
3 times, most recently
from
e2b7b93
to
7400abc
Compare
xDmitriev
reviewed
Aug 6, 2024
There was a problem hiding this comment.
We need to add Docker login in CI for following cases
- before Docekr build
- before kind create
- before image scan
We need to add pull secret in Kind cluster and apply it for the following parts:
- Ingress Helm chart
-- pulling controller image
-- pulling node-helper image
-- pulling certgen image - Nginx workload
We need to have a handler function which will be called in case of exist code is not 0 and perform pod describe using labels (of controller and tarantool pods) and apply this handler for (as mentioned in Slack):
- helm install
- wait for ready pods after helm install
braek-neck
force-pushed
the
NODE-5583
branch
2 times, most recently
from
896b099
to
20ea64c
Compare
xDmitriev
reviewed
Aug 7, 2024
xDmitriev
approved these changes
Aug 7, 2024
braek-neck
force-pushed
the
NODE-5583
branch
3 times, most recently
from
3b50af5
to
dbf2c75
Compare
xDmitriev
reviewed
Aug 8, 2024
xDmitriev
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.