Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues in wallet api #597

Merged
merged 69 commits into from
Jul 31, 2024
Merged

Fix issues in wallet api #597

merged 69 commits into from
Jul 31, 2024

Conversation

SuperBatata
Copy link
Contributor

@SuperBatata SuperBatata commented Jul 9, 2024 •
edited
Loading

Description

Provide a clear and concise description of the changes made in this pull request.

Fixes #592 #593

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

dependabot bot and others added 8 commits July 8, 2024 07:47
@dependabot
build(deps): bump app.softwork:kotlinx-uuid-exposed
afb81c0 
Bumps [app.softwork:kotlinx-uuid-exposed](https://github.com/hfhbd/kotlinx-uuid) from 0.0.25 to 0.0.26.
- [Release notes](https://github.com/hfhbd/kotlinx-uuid/releases)
- [Commits](hfhbd/kotlinx-uuid@v0.0.25...v0.0.26)

---
updated-dependencies:
- dependency-name: app.softwork:kotlinx-uuid-exposed
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
build(deps): bump com.oracle.oci.sdk:oci-java-sdk-shaded-full
f5f4d62 
Bumps com.oracle.oci.sdk:oci-java-sdk-shaded-full from 3.43.2 to 3.44.1.

---
updated-dependencies:
- dependency-name: com.oracle.oci.sdk:oci-java-sdk-shaded-full
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@SuperBatata
fix: wrap register account with try/catch
07911c3
@SuperBatata
fix: add proper error handling
9e5f180
@SuperBatata
fix: fix and add checks on create account parameters
911a469
@SuperBatata
feat: add response message to import key endpoint
8d53547
@SuperBatata
feat: check for existing key before importing
7641ac1
@SuperBatata
Merge remote-tracking branch 'origin/main'
64f1f88
@SuperBatata SuperBatata linked an issue Jul 9, 2024 that may be closed by this pull request
a few 500 Internal Server Errors (SQLITE_CONSTRAINT_PRIMARYKEY) #592
Closed
dependabot bot and others added 15 commits July 9, 2024 14:09
@dependabot
Merge pull request #587 from walt-id/dependabot/gradle/com.oracle.oci…
690aa66 
….sdk-oci-java-sdk-shaded-full-3.44.1
@dependabot
Merge pull request #585 from walt-id/dependabot/gradle/app.softwork-k…
1d183dc 
…otlinx-uuid-exposed-0.0.26
@dependabot
build(deps): bump com.webauthn4j:webauthn4j-core
71d2679 
Bumps [com.webauthn4j:webauthn4j-core](https://github.com/webauthn4j/webauthn4j) from 0.24.1.RELEASE to 0.25.0.RELEASE.
- [Release notes](https://github.com/webauthn4j/webauthn4j/releases)
- [Changelog](https://github.com/webauthn4j/webauthn4j/blob/master/github-release-notes-generator.yml)
- [Commits](webauthn4j/webauthn4j@0.24.1.RELEASE...0.25.0.RELEASE)

---
updated-dependencies:
- dependency-name: com.webauthn4j:webauthn4j-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
build(deps): bump com.google.crypto.tink:tink from 1.13.0 to 1.14.0
d20d5cb 
Bumps [com.google.crypto.tink:tink](https://github.com/tink-crypto/tink-java) from 1.13.0 to 1.14.0.
- [Release notes](https://github.com/tink-crypto/tink-java/releases)
- [Commits](tink-crypto/tink-java@v1.13.0...v1.14.0)

---
updated-dependencies:
- dependency-name: com.google.crypto.tink:tink
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
build(deps): bump org.jetbrains.kotlinx:kotlinx-serialization-json
08a8be3 
Bumps [org.jetbrains.kotlinx:kotlinx-serialization-json](https://github.com/Kotlin/kotlinx.serialization) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/Kotlin/kotlinx.serialization/releases)
- [Changelog](https://github.com/Kotlin/kotlinx.serialization/blob/master/CHANGELOG.md)
- [Commits](Kotlin/kotlinx.serialization@v1.7.0...v1.7.1)

---
updated-dependencies:
- dependency-name: org.jetbrains.kotlinx:kotlinx-serialization-json
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Merge pull request #586 from walt-id/dependabot/gradle/com.webauthn4j…
469ed1b 
…-webauthn4j-core-0.25.0.RELEASE
@dependabot
Merge pull request #584 from walt-id/dependabot/gradle/com.google.cry…
0d4ead5 
…pto.tink-tink-1.14.0
@dependabot
Merge pull request #583 from walt-id/dependabot/gradle/org.jetbrains.…
e362859 
…kotlinx-kotlinx-serialization-json-1.7.1
@SuperBatata
fix: wrap register account with try/catch
973d61c
@SuperBatata
fix: add proper error handling
a83591d
@SuperBatata
fix: fix and add checks on create account parameters
ab4d387
@SuperBatata
feat: add response message to import key endpoint
809af5e
@SuperBatata
feat: check for existing key before importing
98aa148
@SuperBatata
Merge remote-tracking branch 'origin/fix-issues-wallet-api' into fix-…
4657162 
…issues-wallet-api
@SuperBatata
fix: check for existing did before generating
235670f
@SuperBatata SuperBatata marked this pull request as ready for review July 9, 2024 15:34
waltkb
waltkb requested changes Jul 19, 2024
View reviewed changes
waltid-services/waltid-service-commons/src/main/kotlin/id/walt/commons/web/WebExceptions.kt Outdated Show resolved Hide resolved
waltid-services/waltid-service-commons/src/main/kotlin/id/walt/commons/web/WebExceptions.kt Outdated Show resolved Hide resolved
waltid-services/waltid-service-commons/src/main/kotlin/id/walt/commons/web/WebExceptions.kt Outdated Show resolved Hide resolved
...d-services/waltid-service-commons/src/main/kotlin/id/walt/commons/web/plugins/StatusPages.kt Show resolved Hide resolved
...services/waltid-wallet-api/src/main/kotlin/id/walt/webwallet/service/SSIKit2WalletService.kt Outdated Show resolved Hide resolved
.../waltid-wallet-api/src/main/kotlin/id/walt/webwallet/service/account/EmailAccountStrategy.kt Outdated Show resolved Hide resolved
...rvices/waltid-wallet-api/src/main/kotlin/id/walt/webwallet/web/controllers/AuthController.kt Outdated Show resolved Hide resolved
...rvices/waltid-wallet-api/src/main/kotlin/id/walt/webwallet/web/controllers/AuthController.kt Outdated Show resolved Hide resolved
...rvices/waltid-wallet-api/src/main/kotlin/id/walt/webwallet/web/controllers/AuthController.kt Outdated Show resolved Hide resolved
...rvices/waltid-wallet-api/src/main/kotlin/id/walt/webwallet/web/controllers/AuthController.kt Outdated Show resolved Hide resolved
@SuperBatata SuperBatata requested a review from waltkb July 22, 2024 15:18
waltkb
waltkb previously approved these changes Jul 24, 2024
View reviewed changes
@SuperBatata SuperBatata dismissed waltkb’s stale review July 24, 2024 01:23

The merge-base changed after approval.

waltkb
waltkb previously approved these changes Jul 24, 2024
View reviewed changes
@SuperBatata SuperBatata dismissed waltkb’s stale review July 24, 2024 18:01

The merge-base changed after approval.

alegomes
alegomes previously approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@alegomes alegomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions to enhance Dev Experience.

...services/waltid-wallet-api/src/main/kotlin/id/walt/webwallet/service/SSIKit2WalletService.kt Show resolved Hide resolved
...services/waltid-wallet-api/src/main/kotlin/id/walt/webwallet/service/SSIKit2WalletService.kt Show resolved Hide resolved
...services/waltid-wallet-api/src/main/kotlin/id/walt/webwallet/service/SSIKit2WalletService.kt Outdated Show resolved Hide resolved
...ervices/waltid-wallet-api/src/main/kotlin/id/walt/webwallet/web/controllers/DidController.kt Show resolved Hide resolved
@SuperBatata SuperBatata dismissed alegomes’s stale review July 26, 2024 10:58

The merge-base changed after approval.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SuperBatata SuperBatata requested a review from waltkb July 29, 2024 11:41
waltkb
waltkb previously approved these changes Jul 31, 2024
View reviewed changes
@SuperBatata SuperBatata dismissed waltkb’s stale review July 31, 2024 11:43

The merge-base changed after approval.

@waltkb waltkb merged commit 51cb266 into main Jul 31, 2024
4 checks passed
@waltkb waltkb deleted the fix-issues-wallet-api branch August 5, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alegomes alegomes alegomes left review comments

@waltkb waltkb waltkb left review comments

@mikeplotean mikeplotean mikeplotean left review comments

Assignees

@SuperBatata SuperBatata

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@SuperBatata @alegomes @waltkb @mikeplotean