Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

574 category and credential e2e tests #626

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

mikeplotean
Copy link
Contributor

@mikeplotean mikeplotean commented Jul 16, 2024

Description

Adds api tests for category, credentials and exchange wallet endpoints. Fixes a cli test related to illegal path character on Windows.

Fixes #574

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@mikeplotean mikeplotean linked an issue Jul 16, 2024 that may be closed by this pull request
@mikeplotean mikeplotean force-pushed the 574-category-and-credential-e2e-tests branch 2 times, most recently from ccb97ce to f8b2dc4 Compare July 16, 2024 16:33
@mikeplotean mikeplotean force-pushed the 574-category-and-credential-e2e-tests branch 2 times, most recently from 654dd5e to d687b36 Compare July 18, 2024 13:30
@mikeplotean mikeplotean force-pushed the 574-category-and-credential-e2e-tests branch from d687b36 to bc37190 Compare July 19, 2024 11:57
Copy link

sonarcloud bot commented Jul 19, 2024

@mikeplotean mikeplotean merged commit 025a2f2 into main Jul 19, 2024
4 checks passed
@mikeplotean mikeplotean deleted the 574-category-and-credential-e2e-tests branch July 19, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Category and credential e2e tests
2 participants