Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signal handling for Windows compatibility in wapiti.py #625

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Havoc199x
Copy link

This pull request addresses a compatibility issue with Windows by modifying the signal handling in wapiti.py. The following changes were made:

  • Conditional Signal Handling: Added a platform check to ensure that signal handling is only applied on non-Windows systems, preventing the NotImplementedError that occurs on Windows when trying to use asyncio signal handlers.

Background

  • In Wapiti 3.2, attempting to run the program on Windows results in a NotImplementedError due to the loop.add_signal_handler() function, which is unsupported on Windows. This PR ensures compatibility by conditionally adding signal handlers only on systems where it’s supported (e.g., Linux and macOS).

Testing

  • The changes were tested on a Windows system to confirm that they prevent the error and allow Wapiti to run as expected.

Impact

  • This change improves cross-platform compatibility, enabling Windows users to use Wapiti without encountering runtime errors related to signal handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant