Fixing #4. Can now append to file.

Most adapters won't let you append to the file, so it now reads the file and writes the file and message back.
wappr · Nov 26, 2016 · 2e8bfeb · 2e8bfeb
1 parent 87d1709
commit 2e8bfeb
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -42,7 +42,7 @@ use League\Flysystem\Adapter\Local;
 use Psr\Log\LogLevel;
 use wappr\Logger;
 
-$adapter = new Local(__DIR__.'/storage/logs/', FILE_APPEND);
+$adapter = new Local(__DIR__.'/storage/logs/');
 $filesystem = new Filesystem($adapter);
 
 $logger = new Logger($filesystem, LogLevel::DEBUG);
@@ -59,7 +59,7 @@ use League\Flysystem\Adapter\Local;
 use Psr\Log\LogLevel;
 use wappr\Logger;
 
-$adapter = new Local(__DIR__.'/storage/logs/', FILE_APPEND);
+$adapter = new Local(__DIR__.'/storage/logs/');
 $filesystem = new Filesystem($adapter);
 
 $logger = new Logger($filesystem, LogLevel::DEBUG);

diff --git a/src/Logger.php b/src/Logger.php
@@ -91,8 +91,13 @@ public function log($level, $message, array $context = [])
  // Create a new LogFormat instance to format the log entry.
  $message = LogFormat::create($level, $message, $context);
 
- // Get the contents of the file before writing to it. This is so it can be appended.
- $contents = $this->filesystem->read($filename);
+ $contents = '';
+
+ // Check and see if the file exists.
+ if ($this->filesystem->has($filename)) {
+ // Get the contents of the file before writing to it. This is so it can be appended.
+ $contents = $this->filesystem->read($filename);
+ }
 
  $contents .= $message;
 

diff --git a/tests/LogFilenameTest.php b/tests/LogFilenameTest.php
@@ -16,7 +16,7 @@ public function testCreateFilename()
 
  public function testSettingPropertiesInLogger()
  {
- $adapter = new Local(dirname(__DIR__).'/storage/logs/', FILE_APPEND);
+ $adapter = new Local(dirname(__DIR__).'/storage/logs/');
  $filesystem = new Filesystem($adapter);
  $logger = new Logger($filesystem, Psr\Log\LogLevel::INFO);
  $logger->setFilenameFormat('Y-m-d');

diff --git a/tests/LogLevelTest.php b/tests/LogLevelTest.php
@@ -8,7 +8,7 @@ class LogLevelTest extends PHPUnit_Framework_TestCase
 {
  public function testLogLevels()
  {
- $adapter = new Local(dirname(__DIR__).'/storage/logs/', FILE_APPEND);
+ $adapter = new Local(dirname(__DIR__).'/storage/logs/');
  $filesystem = new Filesystem($adapter);
 
  $logger = new Logger($filesystem, Psr\Log\LogLevel::DEBUG);

diff --git a/tests/LoggerImplementationTest.php b/tests/LoggerImplementationTest.php
@@ -8,7 +8,7 @@ class LoggerImplementationTest extends PHPUnit_Framework_TestCase
 {
  public function testIfItImplementsPsrThree()
  {
- $adapter = new Local(dirname(__DIR__).'/storage/logs/', FILE_APPEND);
+ $adapter = new Local(dirname(__DIR__).'/storage/logs/');
  $filesystem = new Filesystem($adapter);
  $logger = new Logger($filesystem, Psr\Log\LogLevel::INFO);
  $this->assertInstanceOf('\Psr\Log\LoggerInterface', $logger);

diff --git a/tests/WriteToFileTest.php b/tests/WriteToFileTest.php
@@ -8,7 +8,7 @@ class WriteToFileTest extends PHPUnit_Framework_TestCase
 {
  public function testWritingToFile()
  {
- $adapter = new Local(dirname(__DIR__).'/storage/logs/', FILE_APPEND);
+ $adapter = new Local(dirname(__DIR__).'/storage/logs/');
  $filesystem = new Filesystem($adapter);
  $logger = new Logger($filesystem, Psr\Log\LogLevel::INFO);
 
@@ -33,7 +33,7 @@ public function testWritingToFile()
 
  public function testNotWritingToFile()
  {
- $adapter = new Local(dirname(__DIR__).'/storage/logs/', FILE_APPEND);
+ $adapter = new Local(dirname(__DIR__).'/storage/logs/');
  $filesystem = new Filesystem($adapter);
  $logger = new Logger($filesystem, Psr\Log\LogLevel::INFO);
 
@@ -58,7 +58,7 @@ public function testNotWritingToFile()
 
  public function testWritingArrayToFile()
  {
- $adapter = new Local(dirname(__DIR__).'/storage/logs/', FILE_APPEND);
+ $adapter = new Local(dirname(__DIR__).'/storage/logs/');
  $filesystem = new Filesystem($adapter);
  $logger = new Logger($filesystem, Psr\Log\LogLevel::INFO);