Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use QuickJS-NG #332

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Use QuickJS-NG #332

wants to merge 9 commits into from

Conversation

wargio
Copy link
Owner

@wargio wargio commented Oct 15, 2024

Adds support to quickjs ng

@wargio
Copy link
Owner Author

wargio commented Oct 15, 2024

@trufae

@wargio wargio changed the title QuickJS-NG Use QuickJS-NG Oct 16, 2024
@satk0
Copy link

satk0 commented Oct 16, 2024

Nice!

@wargio wargio mentioned this pull request Oct 16, 2024
@wargio
Copy link
Owner Author

wargio commented Oct 16, 2024

@trufae if it work for you on iaito, i can merge.

@trufae
Copy link
Contributor

trufae commented Oct 16, 2024

Give me few mins to test and i’ll tell you

This was linked to issues Oct 16, 2024
@trufae
Copy link
Contributor

trufae commented Oct 16, 2024

$ ninja -C b
ninja: Entering directory `b'
[1/6] Generating js/bytecode.h with a custom command
FAILED: js/bytecode.h
/home/pancake/prg/r2dec-js/b/subprojects/libquickjs/qjsc -m -N main_bytecode -o js/bytecode.h ../js/r2dec-plugin.js
Executable output is not supported for this target
ninja: build stopped: subcommand failed.
pancake@pnuc:~/prg/r2dec-js$

@trufae
Copy link
Contributor

trufae commented Oct 16, 2024

doesnt compile for me

@wargio
Copy link
Owner Author

wargio commented Oct 16, 2024

is this a clean build?

@trufae
Copy link
Contributor

trufae commented Oct 16, 2024

Yep. Even in a clean clone

@wargio
Copy link
Owner Author

wargio commented Oct 17, 2024

That is weird, because the test works: https://github.com/wargio/r2dec-js/actions/runs/11359286375/job/31595154681?pr=332

@wargio wargio mentioned this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdd command throws segmentation fault Linking issues
3 participants