chore(wit): Use versioned wasi:logging package
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please run |
Publishing a package that depends on unversioned wit isn't allowed and it requires monkey patching when doing locally anyway. What this does mean is that all go examples need to use the versioned logging interface once we release the new wash. I'll be adding support for that in the host so it really only affects people who currently have Go components. This is probably the easiest path forward for things unfortunately. Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
thomastaylor312
force-pushed
the
chore/use_versioned_logging
branch
from
f5bb825
to
fb1f40f
Compare
We'll need to do a bit more cleanup (like removing the committed deps folder) once wash releases Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
thomastaylor312
force-pushed
the
chore/use_versioned_logging
branch
from
fb1f40f
to
3ee476f
Compare
lxfontes
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publishing a package that depends on unversioned wit isn't allowed and it requires monkey patching when doing locally anyway. What this does mean is that all go examples need to use the versioned logging interface once we release the new wash. I'll be adding support for that in the host so it really only affects people who currently have Go components.
This is probably the easiest path forward for things unfortunately.