fix(observer)!: observe actor annotations instead of spec ID #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
force-pushed
the
feat/propagate-annotations
branch
2 times, most recently
from
12f0d21 to
aec1990
Compare
brooksmtownsend
force-pushed
the
feat/propagate-annotations
branch
from
7d32a27 to
2e5e62b
Compare
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> feat(observer): support annotations on heartbeat Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> reuse existing "legacy" code
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> fix tests Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
brooksmtownsend
force-pushed
the
feat/propagate-annotations
branch
from
2e5e62b to
8c55daf
Compare
connorsmith256
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR updates the lattice observer to keep track of instance annotations rather than just the appspec ID.
Related Issues
Release Information
v0.5.0
Consumer Impact
Testing
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Modified tests to test against an annotations map rather than a single spec ID
Acceptance or Integration
Manual Verification