chore: Update the Github Action to set correct tag for the Docker Image #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sudhanshu Pandey <sp6370@nyu.edu>
Signed-off-by: Sudhanshu Pandey <sp6370@nyu.edu>
Signed-off-by: Sudhanshu Pandey <sp6370@nyu.edu>
Signed-off-by: Sudhanshu Pandey <sp6370@nyu.edu>
Signed-off-by: Sudhanshu Pandey <sp6370@nyu.edu>
Signed-off-by: Sudhanshu Pandey <sp6370@nyu.edu>
Signed-off-by: Sudhanshu Pandey <sp6370@nyu.edu>
Signed-off-by: Sudhanshu Pandey <sp6370@nyu.edu>
Signed-off-by: Sudhanshu Pandey <sp6370@nyu.edu>
Signed-off-by: Sudhanshu Pandey <sp6370@nyu.edu>
Signed-off-by: Sudhanshu Pandey <sp6370@nyu.edu>
Signed-off-by: Sudhanshu Pandey <sp6370@nyu.edu>
joonas
reviewed
Nov 18, 2024
Signed-off-by: Sudhanshu Pandey <sp6370@nyu.edu>
Signed-off-by: Sudhanshu Pandey <sp6370@nyu.edu>
joonas
reviewed
Nov 19, 2024
joonas
reviewed
Nov 19, 2024
Co-authored-by: Joonas Bergius <joonas@users.noreply.github.com> Signed-off-by: Joonas Bergius <joonas@cosmonic.com>
Co-authored-by: Joonas Bergius <joonas@users.noreply.github.com> Signed-off-by: Joonas Bergius <joonas@cosmonic.com>
joonas
approved these changes
Nov 20, 2024
|
Thanks @sp6370! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds support for adding the the release version tag without "v" { 0.10.0 instead of v0.10.0} to the docker images (including wolfi).
I have not removed the existing tagging logic as mentioned in the issue(needs to be keep for some time before complete migration to use the new format).
Closes #465
Note:
The specific approach suggested in here in the issue, doesn't work as Github Action doesn't allow inline string manipulation in expressions.
Testing
Github Action Run with correctly formatted tag: https://github.com/sp6370/wadm_/actions/runs/11905116268/job/33175286269