Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pmtiles support #44

Closed
wants to merge 1 commit into from
Closed

Add pmtiles support #44

wants to merge 1 commit into from

Conversation

slowdub
Copy link

@slowdub slowdub commented Dec 11, 2023

Description

Add support for pmtiles.

Type of Pull Request

  • Adding a feature
  • Fixing a bug
  • Maintaining documents
  • Others ()

Verify the followings

  • Code is up-to-date with the main branch
  • No lint errors after pnpm lint
  • Make sure all the existing features working well

Refer to CONTRIBUTING.MD for more details.

Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for maplibre-gl-export failed.

Name Link
🔨 Latest commit 79d17e3
🔍 Latest deploy log https://app.netlify.com/sites/maplibre-gl-export/deploys/65772b815756fe0008c7b512

@JinIgarashi
Copy link
Member

JinIgarashi commented Dec 11, 2023

@orthotypos Thanks for PR. The code looks good, but I am not sure it is the best way to use addProtocol inside this plugin. I think this plugin should work with PMTiles if you add protocol in your app. Could you try that?

@slowdub
Copy link
Author

slowdub commented Dec 11, 2023

@orthotypos Thanks for PR. The code looks good, but I am not sure it is the best way to use addProtocol inside this plugin. I think this plugin should work with PMTiles if you add protocol in your app. Could you try that?

So, my app already has pmtiles support (via addProtocol), but I was getting this error when trying to print:
"url scheme 'pmtiles' is not supported"

But as I was trying now to create a minimally reproducible setup here, I didn't see the issue anymore. So you're right. it must have been some race condition in my app.
I am closing the PR. Thanks @JinIgarashi !

@slowdub slowdub closed this Dec 11, 2023
@slowdub slowdub deleted the pmtiles-support branch December 11, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants