Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCMat plugin #114

Merged
merged 16 commits into from
Aug 27, 2024
Merged

GCMat plugin #114

merged 16 commits into from
Aug 27, 2024

Conversation

JiaZhou-PU
Copy link
Contributor

@JiaZhou-PU JiaZhou-PU commented Aug 15, 2024 •
edited
Loading

Description

Add GCMat plugin and include one example of GCMat in example folder

Checklist:

  • My code follows the style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have updated the CHANGELOG.md file (if applicable)
  • I have successfully run examples that may be affected by my changes

@JiaZhou-PU JiaZhou-PU marked this pull request as ready for review August 15, 2024 04:00
@JiaZhou-PU
Copy link
Contributor Author

@paulromano @nstauff Ready for review

@JiaZhou-PU JiaZhou-PU changed the title [WIP] GCMat plugin GCMat plugin Aug 15, 2024
nstauff
nstauff requested changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@nstauff nstauff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JiaZhou-PU - this looks quite good but I have a few comments to request improvements in documentation

doc/source/user/plugins.rst Outdated Show resolved Hide resolved
doc/source/user/plugins.rst Outdated Show resolved Hide resolved
examples/1App_GCMat/README.md Outdated Show resolved Hide resolved
examples/1App_GCMat/watts_exec.py Show resolved Hide resolved
examples/1App_GCMat/watts_exec.py Show resolved Hide resolved
examples/1App_GCMat/watts_exec.py Outdated Show resolved Hide resolved
examples/1App_GCMat/watts_exec.py Outdated Show resolved Hide resolved
@JiaZhou-PU
Copy link
Contributor Author

@nstauff Thanks! Comments are addressed, and ready to merge. @paulromano Thank you for the fixes.

nstauff
nstauff approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@nstauff nstauff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JiaZhou-PU

@nstauff nstauff merged commit 1100b78 into watts-dev:development Aug 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nstauff nstauff nstauff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JiaZhou-PU @nstauff @paulromano @danieletimpano