refactor: type-specific 'handlers' #176
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates a repetitive
trySendWith
pattern insenders.realSender
into a simpler pattern.This PR assumes that #175 will be merged first
Old Pattern
New Pattern
In the new pattern, the caller of
trySendWith
only needs to tie together two related things (metric.Line
andpointSender
), whereas before they needed to chose correctly 3 times (metric.Line
,pointHandler
,PointsTracker
).The new pattern also mostly allows us to avoid
line, err
as local variables, so that theSend*
methods can be as short as 1 line.Other opportunistic changes
SendDelta
into a newdelta.Line
funcreporter
tobatchingHTTPReporter
(or maybe it should beHTTPBatchReporter
)Issues
delta.Line
wavefront_sender_test.go
has gotten a little weird - it mocks a 2nd-degree dependency instead of a direct one.LineHandler
andreporter
TypedSender
is not a great name