Merge pull request #80 from lzdyes/main

fix: Google One Tap callback response does not contain clientId
wavezync · Jul 26, 2024 · ff826cb · ff826cb
2 parents 7c15d7d + 1458707
commit ff826cb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/composables/useOneTap.ts b/src/composables/useOneTap.ts
@@ -219,7 +219,7 @@ export default function useOneTap(
  // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
  client_id: clientId!,
  callback: (credentialResponse: CredentialResponse) => {
- if (!credentialResponse.clientId || !credentialResponse.credential) {
+ if (!credentialResponse.credential) {
  onError?.();
  return;
  }

diff --git a/src/interfaces/accounts.ts b/src/interfaces/accounts.ts
@@ -57,12 +57,12 @@ export interface CredentialResponse {
  select_by?: SelectBy;
 
  /**
- * Client ID returned from google
+ * This field is only defined when user clicks a Sign in with Google button to sign in, and the button's state attribute is specified.
  *
  * @type {string}
  * @memberof CredentialResponse
  */
- clientId?: string;
+ state?: string;
 }
 
 /**