Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: add prettier and eslint checks on the changed files for the pull request #6768

Merged

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Jun 13, 2024

Description

This pull request adds the Prettier and ESLint checks on the changed files for the pull requests workflow.

Issues Resolved

#6761

Test

We could test it creating a pull request with changes on the files that do not pass the code format of prettier and eslint. To test, you could use a fork to create the pull request and review the check result for the code formatting (prettier and linter).

Currently, the ESLint check is disabled for this repository, so we could ignore the test of this check.

Check List

  • All tests pass
    • yarn test:jest
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao self-assigned this Jun 13, 2024
@Desvelao Desvelao linked an issue Jun 13, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.94% ( 187 / 893 )
Branches 17.91% ( 79 / 441 )
Functions 13.79% ( 36 / 261 )
Lines 21.14% ( 184 / 870 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.3% ( 4278 / 34779 )
Branches 8.31% ( 1938 / 23294 )
Functions 11.63% ( 964 / 8284 )
Lines 12.48% ( 4168 / 33383 )

@JuanGarriuz
Copy link
Member

JuanGarriuz commented Jun 13, 2024

Test 🟢

Evidence

Faillure

image

image

Success

image
image

@JuanGarriuz JuanGarriuz self-requested a review June 13, 2024 15:16
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@asteriscos asteriscos merged commit 97a1825 into 4.8.1 Jun 13, 2024
5 checks passed
@asteriscos asteriscos deleted the enhancement/6761-add-code-format-check-pull-request-workflow branch June 13, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add code format checks into the pull request checks
4 participants