Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave the date of last modification on a single line on the FIM > Inventory > Windows Registry #6876

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Jul 26, 2024

Description

In FIM > Inventory > Windows Registry table the last modification date was split and made the table bigger, add space and render in 1 line.

Issues Resolved

Evidence

image

Test

  1. Navigate to 'FIM > inventory > windows registry'
  2. View the date

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Jul 26, 2024
@yenienserrano yenienserrano linked an issue Jul 26, 2024 that may be closed by this pull request
@chantal-kelm chantal-kelm self-requested a review July 29, 2024 16:35
@Machi3mfl Machi3mfl self-requested a review July 29, 2024 17:14
@chantal-kelm
Copy link
Member

The date is shown on two lines:

image

Machi3mfl
Machi3mfl previously approved these changes Jul 29, 2024
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Screenshot 2024-07-29 at 14 36 22

@Desvelao
Copy link
Member

Changes

  • Enhance API responses on the mock server

…o bug/6874-the-date-is-split-in-the-windows-registry-in-the-fim-inventory
@Desvelao Desvelao requested a review from Machi3mfl July 30, 2024 10:40
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

…o bug/6874-the-date-is-split-in-the-windows-registry-in-the-fim-inventory
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.63% ( 3990 / 29267 )
Branches 9.12% ( 1746 / 19137 )
Functions 13.34% ( 943 / 7068 )
Lines 13.81% ( 3887 / 28131 )

@Desvelao Desvelao merged commit 85ca71e into 4.9.0 Jul 31, 2024
5 checks passed
@Desvelao Desvelao deleted the bug/6874-the-date-is-split-in-the-windows-registry-in-the-fim-inventory branch July 31, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The date is split in the windows registry in the fim inventory.
4 participants