Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix events data table pagination exception #6917

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Fix events data table pagination exception #6917

merged 4 commits into from
Aug 20, 2024

Conversation

Machi3mfl
Copy link
Member

Description

This PR, solves the error when the user goes to the last page and exceeds the 10000 items.

Closes #6916

Test

  • Go to any Event tab
  • Adjust the filters so that it return more than 10,000 results
  • Click on the last table page
  • No error should be observed

Before

Screen.Recording.2024-08-19.at.12.41.31.mov

After

Screen.Recording.2024-08-19.at.12.40.35.mov

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Machi3mfl Machi3mfl changed the title Fix pagination exception Fix events data table pagination exception Aug 19, 2024
@asteriscos asteriscos linked an issue Aug 19, 2024 that may be closed by this pull request
Events discover pagination exception #6916
Closed
asteriscos
asteriscos requested changes Aug 19, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: 🟢
CR: 🟡

Screenshot from 2024-08-19 18-16-25

plugins/main/public/components/common/search-bar/search-bar-service.ts Outdated Show resolved Hide resolved
@JuanGarriuz JuanGarriuz self-requested a review August 20, 2024 10:05
@JuanGarriuz
Copy link
Member

Test

image

JuanGarriuz
JuanGarriuz previously approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.57% ( 4009 / 29522 )
Branches 9.1% ( 1759 / 19327 )
Functions 13.27% ( 944 / 7111 )
Lines 13.75% ( 3907 / 28406 )

asteriscos
asteriscos approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 🟢

image

@asteriscos asteriscos merged commit a3bf04e into 4.9.0 Aug 20, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/6916-fix-pagination-exception branch August 20, 2024 15:29
This was referenced Aug 21, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@JuanGarriuz JuanGarriuz JuanGarriuz left review comments

Assignees

@Machi3mfl Machi3mfl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Events discover pagination exception
3 participants
@Machi3mfl @JuanGarriuz @asteriscos