New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove delivery of commands and change JobSchedule #204

Merged

AlexRuiz7 merged 8 commits into master from 203-remove-delivery-of-commands

Jan 10, 2025

Member

mcasas993 commented Jan 7, 2025 •

edited by AlexRuiz7

Loading

Description

Remove code related to the delivery of commands.

HttpClient.
Settings.
Deliver of orders from the Job Scheduler job.
Related tests.

Simplify SearchThread (job) to look for expired commands, updating their status.

Issues Resolved

Closes #203


          Remove http client

bf1bba8

mcasas993 requested a review from a team as a code owner

January 7, 2025 23:04

AlexRuiz7 assigned mcasas993

AlexRuiz7 marked this pull request as draft

January 8, 2025 09:25

mcasas993 added 4 commits

January 9, 2025 13:42


          Change the logic of SearchThread to manage the failed commands

95671bc


          Change the parser to only obtain the delivery_timestamp of hit to com…

dbd3e83

…pare


          Delete settings in Command Plugin

5655f6c


          Delete not usage constructor and fix java doc of the new method

mcasas993 marked this pull request as ready for review

January 10, 2025 12:27

AlexRuiz7 reviewed

View reviewed changes

plugins/command-manager/src/main/java/com/wazuh/commandmanager/model/Orders.java Outdated Show resolved Hide resolved

AlexRuiz7 reviewed

View reviewed changes

plugins/command-manager/src/test/java/com/wazuh/commandmanager/CommandManagerTests.java Show resolved Hide resolved

AlexRuiz7 reviewed

View reviewed changes

.../command-manager/src/main/java/com/wazuh/commandmanager/utils/httpclient/HttpRestClient.java Outdated Show resolved Hide resolved

AlexRuiz7 reviewed

View reviewed changes

...mand-manager/src/main/java/com/wazuh/commandmanager/utils/httpclient/AuthHttpRestClient.java Outdated Show resolved Hide resolved

AlexRuiz7 reviewed

View reviewed changes

plugins/command-manager/src/main/java/com/wazuh/commandmanager/settings/PluginSettings.java Outdated Show resolved Hide resolved

AlexRuiz7 reviewed

View reviewed changes

plugins/command-manager/src/test/java/com/wazuh/commandmanager/CommandManagerTests.java Show resolved Hide resolved

AlexRuiz7 reviewed

View reviewed changes

plugins/command-manager/src/main/java/com/wazuh/commandmanager/jobscheduler/SearchThread.java Outdated Show resolved Hide resolved

plugins/command-manager/src/main/java/com/wazuh/commandmanager/jobscheduler/SearchThread.java Outdated Show resolved Hide resolved

plugins/command-manager/src/main/java/com/wazuh/commandmanager/jobscheduler/SearchThread.java Outdated Show resolved Hide resolved

plugins/command-manager/src/main/java/com/wazuh/commandmanager/jobscheduler/SearchThread.java Outdated Show resolved Hide resolved

AlexRuiz7 requested changes

View reviewed changes

Member

AlexRuiz7 left a comment

The imposter/ folder has become useless now. We may need to delete that one. We can always recover it if we need it.

mcasas993 added 3 commits

January 10, 2025 11:42


          Fix comments in pull request

05b9096


          Retrieve the CommandManagerTest class

8f4ce34


          Improve documentation of handlePage

187442d

mcasas993 requested a review from AlexRuiz7

January 10, 2025 15:51

AlexRuiz7 approved these changes

View reviewed changes

This was linked to issues Jan 10, 2025

[BUG] The Command Manager re-autenticates on each request #192

Closed

[BUG] The Command Manager sends the same command more than once #195

Closed

[BUG] testPost_success is flaky #163

Closed

AlexRuiz7 merged commit 9879492 into master

1 check passed

AlexRuiz7 deleted the 203-remove-delivery-of-commands branch

January 10, 2025 16:13

AlexRuiz7 mentioned this pull request

Add Management API CA file field to opensearch.yml #171

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet