forked from opensearch-project/OpenSearch
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid ambiguous wazuh-indexer package naming #486
Labels
Comments
This issue will remain on hold until we decide which method will be used |
3 tasks
3 tasks
AlexRuiz7
changed the title
Avoid duplicated package generation based on commit
Avoid ambiguous wazuh-indexer package naming
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
Note
As the issue modifies the packages generation process, prefix your branch with
ci/
to invoke and test the builder.From Wazuh 5,
wazuh-indexer
packages are composed by several components, thewazuh-indexer
and the plugins. The source code of these components are stores in different Git repositories. We need to unambiguously identify awazuh-indexer
package, whihc is not the case now as the package name only contains the commit SHA from thewazuh-indexer
repo.To ensure that changes on any of the plugins effectively identifies a package, even if the commit in the wazuh-indexer repository is the same, we will suffix the package after the combination of the commit SHA of the 3 repositories together (
wazuh-indexer
,wazuh-indexer-plugins
andwazuh-indexer-reporting
).Use case scenario (current)
State A
Inputs: deb, x64
wazuh-indexer
wazuh-indexer-plugins
wazuh-indexer-reporting
Output:
wazuh-indexer_5.0.0-1_amd64_62e4d4bf072.deb
State A+1
Inputs: deb, x64
wazuh-indexer
wazuh-indexer-plugins
wazuh-indexer-reporting
Output:
wazuh-indexer_5.0.0-1_amd64_62e4d4bf072.deb
Conclusions
Although the wazuh-indexer-plugins repo has new code, the package is not built as there is a package in the S3 bucket suffixed with the same commit SHA.
Use case scenario (expected)
State A
Inputs: deb, x64
wazuh-indexer
wazuh-indexer-plugins
wazuh-indexer-reporting
Output:
wazuh-indexer_5.0.0-1_amd64_62e4d4bf072-4c105dd-3b03eb3.deb
State A+1
Inputs: deb, x64
wazuh-indexer
wazuh-indexer-plugins
wazuh-indexer-reporting
Output:
wazuh-indexer_5.0.0-1_amd64_62e4d4bf072-a7cf4b6-3b03eb3.deb
The text was updated successfully, but these errors were encountered: