-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug symbols to RPMs packages #2880
Merged
ncvicchi
merged 5 commits into
enhancement/9913-generate-debug-symbols
from
2866-add-debug-symbols-to-rpms
Mar 18, 2024
Merged
Add debug symbols to RPMs packages #2880
ncvicchi
merged 5 commits into
enhancement/9913-generate-debug-symbols
from
2866-add-debug-symbols-to-rpms
Mar 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leoquicenoz
force-pushed
the
2866-add-debug-symbols-to-rpms
branch
4 times, most recently
from
March 14, 2024 06:24
1393276
to
1e4ec47
Compare
Leoquicenoz
force-pushed
the
2866-add-debug-symbols-to-rpms
branch
from
March 14, 2024 06:36
1e4ec47
to
98dffe0
Compare
Leoquicenoz
changed the base branch from
master
to
enhancement/9913-generate-debug-symbols
March 14, 2024 06:40
Please, can you share the command that you are using to run the first output? |
ncvicchi
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Generate manager packages $ ./generate_rpm_package.sh -b enhancement/9913-generate-debug-symbols -t manager -a amd64 -s /tmp/test2 --packages-branch 2866-add-debug-symbols-to-rpms
[+] Building 158.0s (9/22)
=> [internal] load build definition from Dockerfile
.
.
.
equires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Requires(pre): /bin/sh /usr/sbin/groupadd /usr/sbin/useradd
Requires(post): /bin/sh
Requires(preun): /bin/sh
Requires(postun): /bin/sh /usr/sbin/groupdel /usr/sbin/userdel
Requires(posttrans): /bin/sh
Conflicts: ossec-hids ossec-hids-agent wazuh-agent wazuh-local
Obsoletes: wazuh-api < 4.0.0
Processing files: wazuh-manager-debuginfo-4.9.0-1.x86_64
Provides: wazuh-manager-debuginfo = 4.9.0-1 wazuh-manager-debuginfo(x86-64) = 4.9.0-1
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Checking for unpackaged file(s): /usr/local/lib/rpm/check-files /build_wazuh/rpmbuild/BUILDROOT/wazuh-manager-4.9.0-1.x86_64
Wrote: /build_wazuh/rpmbuild/SRPMS/wazuh-manager-4.9.0-1.src.rpm
Wrote: /build_wazuh/rpmbuild/RPMS/x86_64/wazuh-manager-debuginfo-4.9.0-1.x86_64.rpm
Wrote: /build_wazuh/rpmbuild/RPMS/x86_64/wazuh-manager-4.9.0-1.x86_64.rpm
Executing(%clean): /bin/sh -e /usr/local/var/tmp/rpm-tmp.a816Bo
+ umask 022
+ cd /build_wazuh/rpmbuild/BUILD
+ cd wazuh-manager-4.9.0
+ rm -fr /build_wazuh/rpmbuild/BUILDROOT/wazuh-manager-4.9.0-1.x86_64
+ RPM_EC=0 ++ jobs -p
+ exit 0
+ [[ no == \y\e\s ]]
+ [[ no == \y\e\s ]]
+ find /build_wazuh/rpmbuild/RPMS/x86_64 -maxdepth 3 -type f -name 'wazuh-manager-4.9.0-1*' -exec mv '{}' /var/local/wazuh ';' + find /build_wazuh/rpmbuild/RPMS/x86_64 -maxdepth 3 -type f -name 'wazuh-manager-debuginfo-4.9.0-1*' -exec mv '{}' /var/local/wazuh ';'
Package wazuh-manager-debuginfo-4.9.0-1.x86_64.rpm wazuh-manager-4.9.0-1.x86_64.rpm added to /tmp/test2. List generated manager packages $ ll -tr /tmp/tests2
-rw-r--r-- 1 root root 33329380 Mar 18 18:29 wazuh-manager-debuginfo-4.9.0-1.x86_64.rpm -rw-r--r-- 1 root root 290441032 Mar 18 18:33 wazuh-manager-4.9.0-1.x86_64.rpm Generate agent packages [+] Building 4.1s (23/23) FINISHED => [internal] load .dockerignore 0.3s
=> => transferring context: 2B 0.0s => [internal] load build definition from Dockerfile 0.5s
=> => transferring dockerfile: 3.37kB 0.0s => [internal] load metadata for docker.io/library/centos:6 2.1s => [internal] load build context 0.2s => => transferring context: 5.49kB 0.0s => [ 1/18] FROM docker.io/library/centos:6@sha256:a93df2e96e07f56ea48f215425c6f1673ab922927894595bb5c0ee4c5a955133 0.0s .
. .
.
warning: Missing build-id in /build_wazuh/rpmbuild/BUILDROOT/wazuh-agent-4.9.0-1.x86_64/usr/lib/debug/var/ossec/bin/manage_agents.debug warning: Missing build-id in /build_wazuh/rpmbuild/BUILDROOT/wazuh-agent-4.9.0-1.x86_64/usr/lib/debug/var/ossec/bin/agent-auth.debug
Provides: wazuh-agent-debuginfo = 4.9.0-1 wazuh-agent-debuginfo(x86-64) = 4.9.0-1
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Checking for unpackaged file(s): /usr/local/lib/rpm/check-files /build_wazuh/rpmbuild/BUILDROOT/wazuh-agent-4.9.0-1.x86_64
Wrote: /build_wazuh/rpmbuild/SRPMS/wazuh-agent-4.9.0-1.src.rpm
Wrote: /build_wazuh/rpmbuild/RPMS/x86_64/wazuh-agent-4.9.0-1.x86_64.rpm
Wrote: /build_wazuh/rpmbuild/RPMS/x86_64/wazuh-agent-debuginfo-4.9.0-1.x86_64.rpm
Executing(%clean): /bin/sh -e /usr/local/var/tmp/rpm-tmp.Jc61Yn
+ umask 022
+ cd /build_wazuh/rpmbuild/BUILD
+ cd wazuh-agent-4.9.0
+ rm -fr /build_wazuh/rpmbuild/BUILDROOT/wazuh-agent-4.9.0-1.x86_64
+ RPM_EC=0
++ jobs -p
+ exit 0
+ [[ no == \y\e\s ]]
+ [[ no == \y\e\s ]]
+ oind /build_wazuh/rpmbuild/RPMS/x86_64 -maxdepth 3 -type f -name 'wazuh-agent-4.9.0-1*' -exec mv '{}' /var/local/wazuh ';'
- find /build_wazuh/rpmbuild/RPMS/x86_64 -maxdepth 3 -type f -name 'wazuh-agent-debuginfo-4.9.0-1*' -exec mv '{}' /var/local/wazuh ';'
-ackage wazuh-agent-4.9.0-1.x86_64.rpm wazuh-agent-debuginfo-4.9.0-1.x86_64.rpm added to /tmp/test. List generated agent packages $ ll /tmp/test/
-rw-r--r-- 1 root root 10687681 Mar 18 13:15 wazuh-agent-4.9.0-1.x86_64.rpm
-rw-r--r-- 1 root root 15746884 Mar 18 13:15 wazuh-agent-debuginfo-4.9.0-1.x86_64.rpm LGTM! |
tdrauncieal
approved these changes
Mar 18, 2024
ncvicchi
merged commit Mar 18, 2024
110d9d5
into
enhancement/9913-generate-debug-symbols
51 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is intended to implement the necessary changes to create the new symbol packages for manager and agent, which can be installed on the endpoint when appropriate.
Logs example
tail of build output
./generate_rpm_package.sh -b 4.9.0 --packages-branch 2866-add-debug-symbols-to-rpms -t agent
packages files generated
wazuh-agent-debuginfo install example
%files
section is correctly updated if necessary