Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lexeme data transclusion returns 'nil' #456

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Fix lexeme data transclusion returns 'nil' #456

merged 1 commit into from
Nov 12, 2024

Conversation

dati18
Copy link
Contributor

@dati18 dati18 commented Nov 8, 2024

Bug: T354376

rosalieper
rosalieper approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@rosalieper rosalieper left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test it locally but LGTM. Happy to see it tried on staging

@dati18 dati18 merged commit 921531b into main Nov 12, 2024
9 checks passed
@dati18 dati18 deleted the lexeme-bug branch November 12, 2024 14:30
dati18 added a commit that referenced this pull request Nov 12, 2024
@dati18
Release 1.39-7.4-20241112-0 (#456)
134cbee
dati18 added a commit that referenced this pull request Nov 12, 2024
@dati18
Release 1.39-7.4-20241112-0 (#456) (#457)
28a061b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosalieper rosalieper rosalieper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dati18 @rosalieper