-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to publish/preview new assets when quick publish from tools config page editor #7
Unable to publish/preview new assets when quick publish from tools config page editor #7
Conversation
@stefanseifert Can you review this MR please? |
@stefanseifert gentle reminder, As I am away after this Friday until next year to do any changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution!
there are some sonar findings (which unfortunately are not visible for external PRs directly in the PR comments), please have a look at https://sonarcloud.io/summary/new_code?id=wcm-io_io.wcm.caconfig.extensions&branch=feature%2Fassetreferences-publishing-support
overall this is the right approach, but there are some open issues.
src/main/java/io/wcm/caconfig/extensions/references/impl/ConfigurationReferenceProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/io/wcm/caconfig/extensions/references/impl/ConfigurationReferenceProvider.java
Outdated
Show resolved
Hide resolved
…e children and array-list references as well
i've refactored the code to cover more edge cases:
i also moved the actual reference detection logic to a separate class to not clutter the main class too much, and make the edge cases testable independent of the other (complex) parts of the reference provider. additionally, i added a new OSGi configuration option which allows to enable the detection of asset, but is disabled by default. so, we can test it a bit if it has performance impact, before enable it for everyone maybe in a later release. |
This is to solve the issue wcm-io/io.wcm.caconfig.editor#47.
ConfigurationReferenceProvider
class is responsible to identify all the ca config references in a pageassets type
referenced in ca config as well asca config type
reference we need to provide asset references which are outdated or newly added.