Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ca config collections - showing as outdated reference when quick publishing #8

Conversation

srikanthgurram-17
Copy link
Contributor

@srikanthgurram-17 srikanthgurram-17 commented Dec 2, 2024

This is to solve wcm-io/io.wcm.caconfig.editor#48

Below is the behaviour of nested configurations :

Current behaviour: When we update or add one config in nested config all the configs inside the nested configs last modified dates are updated.
Expect behaviour: When we update or add a single config in nested config only the config that is added or updated should have last modified date updated

…ishing

Below is the behaviour of nested configurations :

Current behaviour: When we update or add one config in nested config all the configs inside the nested configs last modified dates are updated.
Expect behaviour: When we update or add a single config in nested config only the config that is added or updated should have last modified date updated
@srikanthgurram-17 srikanthgurram-17 marked this pull request as draft December 2, 2024 10:51
@srikanthgurram-17
Copy link
Contributor Author

@stefanseifert please review!

@srikanthgurram-17 srikanthgurram-17 marked this pull request as ready for review December 2, 2024 11:13
@srikanthgurram-17
Copy link
Contributor Author

@stefanseifert gentle reminder, As I am away after Friday until next year to do any changes.

Copy link
Member

@stefanseifert stefanseifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution!

looks very good overall, i have found one edge case as open issue.

@stefanseifert stefanseifert merged commit c5866a4 into wcm-io:develop Dec 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants