fix: required asterisk on password label

[sapayth]

fixes #508

related PR

What we have to do:

Add the asterisk for the required password and confirm the password (only missing on the form preview), live is okay.
Move the password view/eye icon inside the password field.

Summary by CodeRabbit

• New Features
  • Enhanced visual spacing for the wpuf-eye image element in forms.
• Bug Fixes
  • Improved robustness in the form submission logic by ensuring a valid post type is always used.
• Chores
  • Updated translation template with new timestamps and line references.

[coderabbitai]

Walkthrough

The pull request introduces minor CSS adjustments to the wpuf-eye class, enhancing its horizontal positioning. Additionally, it modifies the is_submission_open function in the Form.php file to ensure a default post type is used when none is specified, improving robustness. Updates to the translation template file reflect changes in line references and timestamps without altering functionality. Overall, these changes maintain the existing layout while improving code reliability and translation management.

Changes

File	Change Summary
assets/css/frontend-forms.css	Adjusted right property of img.wpuf-eye from 0 to 1rem.
assets/less/frontend-forms.less	Adjusted right property of img.wpuf-eye from 0 to 1rem.
includes/Admin/Forms/Form.php	Added default value of 'post' for $post_type in is_submission_open function.
languages/wp-user-frontend.pot	Updated timestamps and line references in the translation template file.

Assessment against linked issues

Objective	Addressed	Explanation
Form id specific posts are not displaying on the dashboard (#508)	❌	The changes do not address the post display issue.

Possibly related PRs

• enhance: subscription design followups #1471: Involves CSS changes enhancing the visual presentation of tooltips and headers.
• enhance: move newsletter subscription to weMail #1472: Includes CSS modifications for the subscription box layout, potentially related to form styling.
• fix: translation for password strength #1476: Addresses localization issues for password strength messages, relevant to user interface adjustments.
• fix: translate strings on various pages #1478: Focuses on translating strings across various pages, which could relate to localization improvements.
• fix readonly does not work for 'Teeny Rich textarea' #1479: Fixes read-only functionality for a textarea field, connecting to form handling improvements.

Suggested labels

bug, needs: developer feedback

Poem

🐇 In fields of code, I hop and play,
With changes bright, I greet the day.
A little shift, a post type's grace,
Together we improve this space!
So let us cheer, for forms anew,
With CSS tweaks, our dreams come true! 🌼

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2d97a71 and 091f418.

Files selected for processing (4)

• assets/css/frontend-forms.css (1 hunks)
• assets/less/frontend-forms.less (1 hunks)
• includes/Admin/Forms/Form.php (1 hunks)
• languages/wp-user-frontend.pot (3 hunks)

Files skipped from review due to trivial changes (3)

• assets/css/frontend-forms.css
• assets/less/frontend-forms.less
• languages/wp-user-frontend.pot

Additional comments not posted (2)

includes/Admin/Forms/Form.php (2)

185-185: Good use of null coalescing operator to assign default value.

Using the null coalescing operator here is a safe and concise way to ensure $post_type always has a valid value by assigning a default if $form_settings['post_type'] is empty. This prevents potential issues that could arise from using an undefined or empty $post_type later in the code.

---

187-187: Using $post_type variable improves code readability and maintainability.

The change to use the $post_type variable here, instead of directly accessing $form_settings['post_type'], makes the code more readable and maintainable. It avoids duplication of the post type value and is consistent with the previous change that initializes $post_type with a default value.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.