Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use variable for default runs-on value [skip deploy] #76

Merged
merged 1 commit into from
Dec 3, 2024
Merged

ci: use variable for default runs-on value [skip deploy] #76

merged 1 commit into from
Dec 3, 2024

Conversation

rperryng
Copy link
Contributor

@rperryng rperryng commented Dec 3, 2024

Why

The ubuntu-latest label is is moving to Ubuntu 24 starting Dec 5th, 2024.

We are changing repositories to use an org-wide variable currently set to ubuntu-22.04.

  • Ubuntu 22 is an LTS release and should remain supported until 2027.
  • Using an org-wide actions variable makes it easier to mass-migrate repos in the future, while still making it relatively easy to customize per-repo, if necessary, using a repostory-level variable to override the org-wide one.

What Changed

  • Replace usage of ubuntu-latest / ubuntu-22.04 with ${{ vars.DEFAULT_RUNS_ON }} in workflow files

@rperryng rperryng requested review from a team as code owners December 3, 2024 02:27
cchawn
cchawn approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@cchawn cchawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!
🚀 🚀

@rperryng rperryng merged commit bb4f45c into main Dec 3, 2024
7 checks passed
@rperryng rperryng deleted the beplat-1548-runs-on-defaults-to-var branch December 3, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchawn cchawn cchawn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rperryng @cchawn