prevent cmdk short keys

weareunderdesign · Dec 14, 2023 · eb46131 · eb46131
1 parent 83be97b
commit eb46131
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 31 deletions.
diff --git a/src/components/main/stageView/iFrame/hooks/useCmdk.ts b/src/components/main/stageView/iFrame/hooks/useCmdk.ts
@@ -78,17 +78,6 @@ export const useCmdk = ({
           break; // Match found, exit the outer loop
         }
       }
-      // prevent chrome default short keys
-      if (
-        action === "Save" ||
-        action === "Download" ||
-        action === "Duplicate" ||
-        action === "Group" ||
-        action === "UnGroup"
-      ) {
-        e.preventDefault();
-      }
-
       if (isEditingRef.current) {
         // for content-editing
         if (
@@ -133,6 +122,8 @@ export const useCmdk = ({
           dispatch(setCurrentCommand({ action }));
         }
       }
+
+      action && e.preventDefault();
     },
     [osType, cmdkReferenceData],
   );

diff --git a/src/pages/main/hooks/useCmdk.ts b/src/pages/main/hooks/useCmdk.ts
@@ -274,22 +274,14 @@ export const useCmdk = ({ cmdkReferenceData, importProject }: IUseCmdk) => {
           break; // Match found, exit the outer loop
         }
       }
-      // prevent chrome default short keys
-      if (
-        action === "Save" ||
-        action === "Download" ||
-        action === "Duplicate" ||
-        action === "Group" ||
-        action === "UnGroup"
-      ) {
-        e.preventDefault();
-      }
-
-      if (cmdkOpen) return;
       if (action) {
-        LogAllow && console.log("action to be run by cmdk: ", action);
-        dispatch(setCurrentCommand({ action }));
+        if (!cmdkOpen) {
+          LogAllow && console.log("action to be run by cmdk: ", action);
+          dispatch(setCurrentCommand({ action }));
+        }
       }
+
+      action && e.preventDefault();
     },
     [osType, cmdkOpen, cmdkReferenceData],
   );

diff --git a/src/pages/main/hooks/useCmdkModal.ts b/src/pages/main/hooks/useCmdkModal.ts
@@ -21,13 +21,8 @@ export const useCmdkModal = () => {
     string | null | undefined
   >();
 
-  const debouncedCmdkOpen = useCallback(
-    debounce(() => dispatch(setCmdkOpen(true)), ShortDelay),
-    [],
-  );
   useEffect(() => {
-    cmdkPages.length && debouncedCmdkOpen();
-    // cmdkPages.length && dispatch(setCmdkOpen(true));
+    cmdkPages.length && dispatch(setCmdkOpen(true));
     dispatch(setCurrentCmdkPage([...cmdkPages].pop() || ""));
   }, [cmdkPages]);
   useEffect(() => {