fix(create-rspack): remove useless sourceMap option in templates (#6319)

* fix(create-rspack): remove useless sourceMap option * docs: remove sourceMaps: true
web-infra-dev · Apr 23, 2024 · 6f80f58 · 6f80f58 · rspack-bot · Apr 23, 2024
1 parent 81c41c8
commit 6f80f58
Show file tree

Hide file tree

Showing 22 changed files with 11 additions and 42 deletions.
diff --git a/diffcases/arco-pro/rspack.config.js b/diffcases/arco-pro/rspack.config.js
@@ -36,7 +36,7 @@ const config = {
 				exclude: [/[\\/]node_modules[\\/]/],
 				loader: "builtin:swc-loader",
 				options: {
-					sourceMap: false,
+					sourceMaps: false,
 					jsc: {
 						parser: {
 							syntax: "typescript"
@@ -53,7 +53,7 @@ const config = {
 				loader: "builtin:swc-loader",
 				exclude: [/[\\/]node_modules[\\/]/],
 				options: {
-					sourceMap: false,
+					sourceMaps: false,
 					jsc: {
 						parser: {
 							syntax: "typescript",

diff --git a/diffcases/arco-pro/webpack.config.js b/diffcases/arco-pro/webpack.config.js
@@ -3,7 +3,7 @@ const HtmlWebpackPlugin = require("html-webpack-plugin");
 
 /** @type {import('webpack').Configuration} */
 const config = {
-	mode: 'production',
+	mode: "production",
 	context: __dirname,
 	entry: "./src/index.tsx",
 	target: ["web", "es5"],
@@ -13,7 +13,7 @@ const config = {
 				test: /\.less$/,
 				use: "less-loader",
 				parser: {
-					namedExports: false,
+					namedExports: false
 				},
 				generator: {
 					exportsOnly: true
@@ -40,7 +40,7 @@ const config = {
 				exclude: [/[\\/]node_modules[\\/]/],
 				loader: "swc-loader",
 				options: {
-					sourceMap: false,
+					sourceMaps: false,
 					jsc: {
 						parser: {
 							syntax: "typescript"
@@ -57,7 +57,7 @@ const config = {
 				loader: "swc-loader",
 				exclude: [/[\\/]node_modules[\\/]/],
 				options: {
-					sourceMap: false,
+					sourceMaps: false,
 					jsc: {
 						parser: {
 							syntax: "typescript",
@@ -90,7 +90,7 @@ const config = {
 			// expression, which causes stack overflow for swc parser in debug mode.
 			// Alias to the unminified version mitigates this problem.
 			// See also <https://github.com/search?q=repo%3Aswc-project%2Fswc+parser+stack+overflow&type=issues>
-			mockjs: require.resolve("./patches/mock.js"),
+			mockjs: require.resolve("./patches/mock.js")
 		},
 		extensions: [".js", ".jsx", ".ts", ".tsx", ".css", ".less"]
 	},
@@ -127,10 +127,10 @@ const config = {
 			title: "Arco Pro App",
 			template: path.join(__dirname, "index.html"),
 			favicon: path.join(__dirname, "public", "favicon.ico")
-		}),
+		})
 	],
 	infrastructureLogging: {
 		debug: false
-	},
+	}
 };
 module.exports = config;
diff --git a/packages/create-rspack/template-react-ts/rspack.config.js b/packages/create-rspack/template-react-ts/rspack.config.js
@@ -24,7 +24,6 @@ module.exports = {
 					{
 						loader: "builtin:swc-loader",
 						options: {
-							sourceMap: true,
 							jsc: {
 								parser: {
 									syntax: "typescript",

diff --git a/packages/create-rspack/template-react/rspack.config.js b/packages/create-rspack/template-react/rspack.config.js
@@ -24,7 +24,6 @@ module.exports = {
 					{
 						loader: "builtin:swc-loader",
 						options: {
-							sourceMap: true,
 							jsc: {
 								parser: {
 									syntax: "typescript",

diff --git a/packages/create-rspack/template-vue/rspack.config.js b/packages/create-rspack/template-vue/rspack.config.js
@@ -31,7 +31,6 @@ const config = {
 					{
 						loader: "builtin:swc-loader",
 						options: {
-							sourceMap: true,
 							jsc: {
 								parser: {
 									syntax: "typescript",

diff --git a/packages/rspack-test-tools/rspack.config.js b/packages/rspack-test-tools/rspack.config.js
@@ -25,7 +25,7 @@ module.exports = {
 				exclude: [/[\\/]node_modules[\\/]/],
 				loader: "builtin:swc-loader",
 				options: {
-					sourceMap: false,
+					sourceMaps: false,
 					jsc: {
 						parser: {
 							syntax: "typescript"
@@ -42,7 +42,7 @@ module.exports = {
 				loader: "builtin:swc-loader",
 				exclude: [/[\\/]node_modules[\\/]/],
 				options: {
-					sourceMap: false,
+					sourceMaps: false,
 					jsc: {
 						parser: {
 							syntax: "typescript",

diff --git a/packages/rspack/tests/configCases/builtin-swc-loader/inline-pitching/webpack.config.js b/packages/rspack/tests/configCases/builtin-swc-loader/inline-pitching/webpack.config.js
@@ -10,8 +10,6 @@ module.exports = {
 					{
 						loader: "builtin:swc-loader",
 						options: {
-							// Enable source map
-							sourceMap: true,
 							jsc: {
 								parser: {
 									syntax: "typescript",

diff --git a/packages/rspack/tests/configCases/builtin-swc-loader/react-runtime-automic/webpack.config.js b/packages/rspack/tests/configCases/builtin-swc-loader/react-runtime-automic/webpack.config.js
@@ -9,7 +9,6 @@ module.exports = {
 				test: /\.jsx$/,
 				loader: "builtin:swc-loader",
 				options: {
-					sourceMap: true,
 					jsc: {
 						parser: {
 							syntax: "ecmascript",

diff --git a/packages/rspack/tests/configCases/builtin-swc-loader/react-runtime-classic/webpack.config.js b/packages/rspack/tests/configCases/builtin-swc-loader/react-runtime-classic/webpack.config.js
@@ -9,7 +9,6 @@ module.exports = {
 				test: /\.jsx$/,
 				loader: "builtin:swc-loader",
 				options: {
-					sourceMap: true,
 					jsc: {
 						parser: {
 							syntax: "ecmascript",

diff --git a/packages/rspack/tests/configCases/builtin-swc-loader/swc-plugin/webpack.config.js b/packages/rspack/tests/configCases/builtin-swc-loader/swc-plugin/webpack.config.js
@@ -7,7 +7,6 @@ module.exports = {
 				use: {
 					loader: "builtin:swc-loader",
 					options: {
-						sourceMap: true,
 						jsc: {
 							parser: {
 								syntax: "typescript",

diff --git a/packages/rspack/tests/configCases/loader/loader-builtin-swc/webpack.config.js b/packages/rspack/tests/configCases/loader/loader-builtin-swc/webpack.config.js
@@ -7,8 +7,6 @@ module.exports = {
 				use: {
 					loader: "builtin:swc-loader",
 					options: {
-						// Enable source map
-						sourceMap: true,
 						jsc: {
 							parser: {
 								syntax: "typescript",

diff --git a/packages/rspack/tests/configCases/source-map/source-map/webpack.config.js b/packages/rspack/tests/configCases/source-map/source-map/webpack.config.js
@@ -12,7 +12,6 @@ module.exports = {
 				test: /\.jsx$/,
 				loader: "builtin:swc-loader",
 				options: {
-					sourceMap: true,
 					jsc: {
 						parser: {
 							syntax: "ecmascript",

diff --git a/website/docs/en/blog/announcing-0.3.mdx b/website/docs/en/blog/announcing-0.3.mdx
@@ -133,8 +133,6 @@ const config = {
         use: {
           loader: 'builtin:swc-loader',
           options: {
-            // Enable source map
-            sourceMap: true,
             jsc: {
               parser: {
                 syntax: 'ecmascript',

diff --git a/website/docs/en/blog/announcing-0.5.mdx b/website/docs/en/blog/announcing-0.5.mdx
@@ -45,7 +45,6 @@ module.exports = {
         exclude: /[\\/]node_modules[\\/]/,
         loader: 'builtin:swc-loader',
         options: {
-          sourceMaps: true,
           jsc: {
             parser: {
               syntax: 'ecmascript',
@@ -70,7 +69,6 @@ module.exports = {
         exclude: /[\\/]node_modules[\\/]/,
         loader: 'builtin:swc-loader',
         options: {
-          sourceMaps: true,
           jsc: {
             parser: {
               syntax: 'typescript',
@@ -95,7 +93,6 @@ module.exports = {
         exclude: /[\\/]node_modules[\\/]/,
         loader: 'builtin:swc-loader',
         options: {
-          sourceMaps: true,
           jsc: {
             parser: {
               syntax: 'typescript',

diff --git a/website/docs/en/guide/builtin-swc-loader.mdx b/website/docs/en/guide/builtin-swc-loader.mdx
@@ -21,7 +21,6 @@ module.exports = {
         exclude: [/node_modules/],
         loader: 'builtin:swc-loader',
         options: {
-          sourceMaps: true,
           jsc: {
             parser: {
               syntax: 'typescript',
@@ -46,7 +45,6 @@ module.exports = {
         use: {
           loader: 'builtin:swc-loader',
           options: {
-            sourceMaps: true,
             jsc: {
               parser: {
                 syntax: 'ecmascript',

diff --git a/website/docs/en/guide/migrate-from-webpack.mdx b/website/docs/en/guide/migrate-from-webpack.mdx
@@ -43,7 +43,6 @@ module.exports = {
 +        exclude: [/[\\/]node_modules[\\/]/],
 +        loader: 'builtin:swc-loader',
 +        options: {
-+          sourceMap: true,
 +          jsc: {
 +            parser: {
 +              syntax: 'typescript',
@@ -67,7 +66,6 @@ module.exports = {
 +        loader: 'builtin:swc-loader',
 +        exclude: [/[\\/]node_modules[\\/]/],
 +        options: {
-+          sourceMap: true,
 +          jsc: {
 +            parser: {
 +              syntax: 'typescript',

diff --git a/website/docs/en/guide/vue.mdx b/website/docs/en/guide/vue.mdx
@@ -109,7 +109,6 @@ module.exports = {
         test: /\.ts$/, // add this rule when you use typescript in Vue SFC
         loader: 'builtin:swc-loader',
         options: {
-          sourceMaps: true,
           jsc: {
             parser: {
               syntax: 'typescript',

diff --git a/website/docs/zh/blog/announcing-0.3.mdx b/website/docs/zh/blog/announcing-0.3.mdx
@@ -134,8 +134,6 @@ const config = {
         use: {
           loader: 'builtin:swc-loader',
           options: {
-            // Enable source map
-            sourceMap: true,
             jsc: {
               parser: {
                 syntax: 'ecmascript',

diff --git a/website/docs/zh/blog/announcing-0.5.mdx b/website/docs/zh/blog/announcing-0.5.mdx
@@ -45,7 +45,6 @@ module.exports = {
         exclude: /[\\/]node_modules[\\/]/,
         loader: 'builtin:swc-loader',
         options: {
-          sourceMaps: true,
           jsc: {
             parser: {
               syntax: 'ecmascript',
@@ -70,7 +69,6 @@ module.exports = {
         exclude: /[\\/]node_modules[\\/]/,
         loader: 'builtin:swc-loader',
         options: {
-          sourceMaps: true,
           jsc: {
             parser: {
               syntax: 'typescript',
@@ -95,7 +93,6 @@ module.exports = {
         exclude: /[\\/]node_modules[\\/]/,
         loader: 'builtin:swc-loader',
         options: {
-          sourceMaps: true,
           jsc: {
             parser: {
               syntax: 'typescript',

diff --git a/website/docs/zh/guide/builtin-swc-loader.mdx b/website/docs/zh/guide/builtin-swc-loader.mdx
@@ -21,7 +21,6 @@ module.exports = {
         exclude: [/node_modules/],
         loader: 'builtin:swc-loader',
         options: {
-          sourceMaps: true,
           jsc: {
             parser: {
               syntax: 'typescript',
@@ -46,7 +45,6 @@ module.exports = {
         use: {
           loader: 'builtin:swc-loader',
           options: {
-            sourceMaps: true,
             jsc: {
               parser: {
                 syntax: 'ecmascript',

diff --git a/website/docs/zh/guide/migrate-from-webpack.mdx b/website/docs/zh/guide/migrate-from-webpack.mdx
@@ -43,7 +43,6 @@ module.exports = {
 +        exclude: [/[\\/]node_modules[\\/]/],
 +        loader: 'builtin:swc-loader',
 +        options: {
-+          sourceMap: true,
 +          jsc: {
 +            parser: {
 +              syntax: 'typescript',
@@ -67,7 +66,6 @@ module.exports = {
 +        loader: 'builtin:swc-loader',
 +        exclude: [/[\\/]node_modules[\\/]/],
 +        options: {
-+          sourceMap: true,
 +          jsc: {
 +            parser: {
 +              syntax: 'typescript',

diff --git a/website/docs/zh/guide/vue.mdx b/website/docs/zh/guide/vue.mdx
@@ -109,7 +109,6 @@ module.exports = {
         test: /\.ts$/, // 如果需要在 Vue SFC 里使用 TypeScript, 请添加该规则
         loader: 'builtin:swc-loader',
         options: {
-          sourceMaps: true,
           jsc: {
             parser: {
               syntax: 'typescript',
suite	result
modernjs, self-hosted, Linux, ci	❌ failure
_selftest, ubuntu-latest	✅ success
nx, ubuntu-latest	✅ success
rspress, ubuntu-latest	✅ success
rsbuild, ubuntu-latest	✅ success
compat, ubuntu-latest	✅ success
examples, ubuntu-latest	✅ success
Name	Base (2024-04-23 81c41c8)	Current	Change
10000_development-mode + exec	2.69 s ± 45 ms	2.68 s ± 25 ms	-0.41 %
10000_development-mode_hmr + exec	682 ms ± 2.6 ms	685 ms ± 5.3 ms	+0.44 %
10000_production-mode + exec	2.5 s ± 29 ms	2.51 s ± 37 ms	+0.34 %
arco-pro_development-mode + exec	2.51 s ± 77 ms	2.47 s ± 61 ms	-1.50 %
arco-pro_development-mode_hmr + exec	430 ms ± 2 ms	430 ms ± 2.4 ms	+0.02 %
arco-pro_development-mode_hmr_intercept-plugin + exec	441 ms ± 4.3 ms	443 ms ± 0.92 ms	+0.32 %
arco-pro_development-mode_intercept-plugin + exec	3.21 s ± 65 ms	3.26 s ± 61 ms	+1.60 %
arco-pro_production-mode + exec	3.95 s ± 87 ms	3.98 s ± 66 ms	+0.77 %
arco-pro_production-mode_intercept-plugin + exec	4.69 s ± 55 ms	4.69 s ± 205 ms	-0.09 %
threejs_development-mode_10x + exec	2.06 s ± 20 ms	2.06 s ± 40 ms	-0.16 %
threejs_development-mode_10x_hmr + exec	748 ms ± 8.2 ms	745 ms ± 4.9 ms	-0.35 %
threejs_production-mode_10x + exec	5.15 s ± 49 ms	5.17 s ± 35 ms	+0.31 %