fix(rspack-resolver): enable pnp feature (#7707)

web-infra-dev · Aug 27, 2024 · a78cbde · a78cbde · rspack-bot · Aug 27, 2024
1 parent d266313
commit a78cbde
Show file tree

Hide file tree

Showing 3 changed files with 139 additions and 1 deletion.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/rspack_core/Cargo.toml b/crates/rspack_core/Cargo.toml
@@ -38,7 +38,7 @@ rspack_loader_runner = { version = "0.1.0", path = "../rspack_loader_runner" }
 rspack_macros = { version = "0.1.0", path = "../rspack_macros" }
 rspack_paths = { version = "0.1.0", path = "../rspack_paths" }
 rspack_regex = { version = "0.1.0", path = "../rspack_regex" }
-rspack_resolver = { version = "0.3.0", features = ["package_json_raw_json_api"] }
+rspack_resolver = { version = "0.3.0", features = ["package_json_raw_json_api", "yarn_pnp"] }
 rspack_sources = { workspace = true }
 rspack_util = { version = "0.1.0", path = "../rspack_util" }
 rustc-hash = { workspace = true }

diff --git a/crates/rspack_core/src/resolver/resolver_impl.rs b/crates/rspack_core/src/resolver/resolver_impl.rs
@@ -283,6 +283,7 @@ fn to_rspack_resolver_options(
     roots,
     builtin_modules: false,
     imports_fields,
+    pnp_manifest: None,
   }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -283,6 +283,7 @@ fn to_rspack_resolver_options( @@
         roots,
         builtin_modules: false,
         imports_fields,
+        pnp_manifest: None,
       }
     }
@@ Expand Down @@
Name	Base (2024-08-27 a33dd61)	Current	Change
10000_development-mode + exec	2.27 s ± 31 ms	2.27 s ± 36 ms	-0.20 %
10000_development-mode_hmr + exec	701 ms ± 13 ms	709 ms ± 11 ms	+1.19 %
10000_production-mode + exec	2.94 s ± 44 ms	2.96 s ± 27 ms	+0.52 %
arco-pro_development-mode + exec	1.9 s ± 81 ms	1.85 s ± 62 ms	-2.32 %
arco-pro_development-mode_hmr + exec	435 ms ± 2.4 ms	436 ms ± 2.6 ms	+0.24 %
arco-pro_production-mode + exec	3.4 s ± 84 ms	3.47 s ± 61 ms	+2.17 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.49 s ± 69 ms	3.49 s ± 70 ms	-0.17 %
threejs_development-mode_10x + exec	1.7 s ± 13 ms	1.69 s ± 17 ms	-0.50 %
threejs_development-mode_10x_hmr + exec	829 ms ± 9.9 ms	816 ms ± 2 ms	-1.60 %
threejs_production-mode_10x + exec	5.48 s ± 30 ms	5.49 s ± 13 ms	+0.04 %
suite	result
modernjs	✅ success
_selftest	✅ success
nx	❌ failure
rspress	✅ success
rslib	❌ failure
rsbuild	✅ success
examples	✅ success