Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shutdown hook #3234

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

edusperoni
Copy link
Contributor

@edusperoni edusperoni commented May 19, 2023

Related issue (if exists)

#3158

Summary

This solves the issue with Angular's Sass plugin (see linked issue)

🤖 Generated by Copilot at 744b01b

Added a shutdown hook for compiler plugins and improved error handling in compiler.ts. This enables plugins to release resources and avoid cache corruption.

Walkthrough

🤖 Generated by Copilot at 744b01b

  • Add a new shutdown hook to the Compiler class that allows plugins to perform cleanup or finalization tasks (link, link)
  • Modify the close method of the Compiler class to accept an error argument in the callback function and propagate any errors from the shutdown process (link, link)
  • Invoke the shutdown hook before closing the cache in the close method and only shut down the cache if no errors are reported (link)

@hardfist hardfist added this pull request to the merge queue May 23, 2023
Merged via the queue into web-infra-dev:main with commit fbaac57 May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants