Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: worker support #3617

Merged
merged 6 commits into from
Jun 30, 2023
Merged

feat: worker support #3617

merged 6 commits into from
Jun 30, 2023

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Jun 25, 2023

Summary

resolve #3074

checkout example/worker for example

Feature:

  • output.workerChunkLoading
  • output.workerWasmLoading
  • output.workerPublicPath
  • worker with output.module: true

Todo:

Test Plan

example/worker works, and some tests block by #3658, #3655, #2408, will add more tests after blockers resolved

@github-actions github-actions bot added release: feature team The issue/pr is created by the member of Rspack. labels Jun 25, 2023
@h-a-n-a h-a-n-a added the need documentation Create a tracking issue in rspack-website label Jun 27, 2023
@ahabhgk ahabhgk force-pushed the worker-plugin branch 2 times, most recently from e29a768 to ce2a6ad Compare June 29, 2023 06:49
@ahabhgk ahabhgk marked this pull request as ready for review June 29, 2023 06:51
@ahabhgk ahabhgk requested review from a team June 29, 2023 06:51
@ahabhgk ahabhgk requested review from h-a-n-a and Boshen as code owners June 29, 2023 06:51
@ahabhgk ahabhgk requested a review from underfin June 29, 2023 06:51
@IWANABETHATGUY
Copy link
Contributor

!bench

@github-actions
Copy link
Contributor

Benchmark Results

group                                                 baseline                               pr
-----                                                 --------                               --
criterion_benchmark/ten_copy_of_threejs               1.00       2.9±0.07s        ? ?/sec    1.00       2.9±0.07s        ? ?/sec
high_cost_benchmark/ten_copy_of_threejs_production    1.02      10.1±0.12s        ? ?/sec    1.00       9.9±0.10s        ? ?/sec

underfin
underfin previously approved these changes Jun 29, 2023
ahabhgk added 6 commits June 29, 2023 19:43
basic support

works

feat: worker options

update example

update

feat: more worker options

wip: more worker syntex

sytax scanner
@ahabhgk ahabhgk added this pull request to the merge queue Jun 30, 2023
Merged via the queue into main with commit f3ad8bf Jun 30, 2023
@ahabhgk ahabhgk deleted the worker-plugin branch June 30, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need documentation Create a tracking issue in rspack-website team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WorkerDependency
4 participants