Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add comparator for diff tester #5014

Merged
merged 4 commits into from
Dec 21, 2023
Merged

chore: add comparator for diff tester #5014

merged 4 commits into from
Dec 21, 2023

Conversation

LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Dec 14, 2023 •
edited
Loading

Summary

Re-implement #5002

Test Plan

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Dec 14, 2023
@LingyuCoder
Copy link
Contributor Author

!canary

@github-actions GitHub Actions
Copy link
Contributor

0.4.3-canary-db7596a-20231214062915

@LingyuCoder
Copy link
Contributor Author

!canary

@github-actions GitHub Actions
Copy link
Contributor

0.4.3-canary-91bf22f-20231214073810

@LingyuCoder LingyuCoder marked this pull request as ready for review December 14, 2023 07:45
@LingyuCoder
Copy link
Contributor Author

!diff

@github-actions GitHub Actions
Copy link
Contributor

arco-pro

Runtime Modules Rspack Only Common Webpack Only Common Percent
Modules 3 13 0 81.25%
Lines 169 181 12 50.00%
Lines(Common Modules) 14 181 12 87.44%
Normal Modules Rspack Only Common Webpack Only Common Percent
Modules 2 310 562 35.47%
Lines 2047 15521 52689 22.09%
Lines(Common Modules) 2023 15521 1053 83.46%

View diff report

@LingyuCoder
Copy link
Contributor Author

!canary

@LingyuCoder LingyuCoder force-pushed the chore/diff-comparator branch from 91bf22f to 062cc0e Compare December 19, 2023 10:59
@LingyuCoder
Copy link
Contributor Author

!canary

@github-actions GitHub Actions
Copy link
Contributor

0.4.3-canary-062cc0e-20231219114148

@LingyuCoder LingyuCoder merged commit 32efa04 into main Dec 21, 2023
16 checks passed
@LingyuCoder LingyuCoder deleted the chore/diff-comparator branch December 21, 2023 03:27
ahabhgk pushed a commit that referenced this pull request Jan 2, 2024
@LingyuCoder @ahabhgk
chore: add comparator for diff tester (#5014)
8228c2c 
* fix: pre-build viewer of test tools

* chore: add comparator

* chore: add comparator

* chore: add comparator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerrykingxyz jerrykingxyz jerrykingxyz approved these changes

@hardfist hardfist Awaiting requested review from hardfist

Assignees

@LingyuCoder LingyuCoder

Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LingyuCoder @jerrykingxyz