fix: containerShareScope should get value by shareScope key #6248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release: bug fix
ahabhgk
force-pushed
the
fix/update-federation-runtime
branch
from
4b35db5 to
a2d1e40
Compare
2heal1
changed the title
ahabhgk
force-pushed
the
fix/mf-share-scope-test
branch
from
3399145 to
6aeecbd
Compare
ahabhgk
added a commit
that referenced
this pull request
Apr 17, 2024
* fix(core): update module federation runtime * test(core): update module federation unit tests * add patch * fix * fix * fix: containerShareScope should get value by shareScope key (#6248) * chore: every container should has unique name * fix: containerShareScope should get value by shareScope key --------- Co-authored-by: ScriptedAlchemy <zackaryjackson@bytedance.com> Co-authored-by: ahabhgk <ahabhgk@gmail.com> Co-authored-by: Hanric <TwoHeal@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: containerShareScope should get value by shareScope key
Summary
Checklist