Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(binding): fix type error of binding.d.ts; add test for binding.d.ts #6274

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

xc2
Copy link
Collaborator

@xc2 xc2 commented Apr 17, 2024

In addtion to #6265

Fix jupyterlab/jupyterlab#16005 (comment)

Also included:

  • Test for binding.d.ts (just a simple but useful tsc call)
  • custom dts header of binding.d.ts for type re-use

Related error

binding.d.ts:751:13 - error TS2304: Cannot find name 'JsFilename'.

751   filename: JsFilename
                ~~~~~~~~~~

binding.d.ts:752:18 - error TS2304: Cannot find name 'JsFilename'.

752   chunkFilename: JsFilename
                     ~~~~~~~~~~

binding.d.ts:1078:34 - error TS2552: Cannot find name 'PathData'. Did you mean 'JsPathData'?

1078   filename: string | ((pathData: PathData, assetInfo?: JsAssetInfo) => string)
                                      ~~~~~~~~

binding.d.ts:1079:39 - error TS2552: Cannot find name 'PathData'. Did you mean 'JsPathData'?

1079   chunkFilename: string | ((pathData: PathData, assetInfo?: JsAssetInfo) => string)
                                           ~~~~~~~~

binding.d.ts:1081:37 - error TS2552: Cannot find name 'PathData'. Did you mean 'JsPathData'?

1081   cssFilename: string | ((pathData: PathData, assetInfo?: JsAssetInfo) => string)
                                         ~~~~~~~~

binding.d.ts:1082:42 - error TS2552: Cannot find name 'PathData'. Did you mean 'JsPathData'?

1082   cssChunkFilename: string | ((pathData: PathData, assetInfo?: JsAssetInfo) => string)
                                              ~~~~~~~~


Found 6 errors in the same file, starting at: binding.d.ts:751

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required). no need

@xc2
Copy link
Collaborator Author

xc2 commented Apr 17, 2024

!canary

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Apr 17, 2024
Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 275dfbd
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66213432fd9a6700081115f5

@xc2
Copy link
Collaborator Author

xc2 commented Apr 17, 2024

!canary

@xc2 xc2 marked this pull request as draft April 17, 2024 17:06
@xc2
Copy link
Collaborator Author

xc2 commented Apr 17, 2024

!canary

@xc2 xc2 marked this pull request as ready for review April 17, 2024 17:25
Copy link
Contributor

0.6.2-canary-9f58a91-20240417174925

@xc2 xc2 requested review from ahabhgk and h-a-n-a April 18, 2024 09:43
@xc2 xc2 force-pushed the fix/binding-type branch from 9f58a91 to 275dfbd Compare April 18, 2024 14:54
@h-a-n-a
Copy link
Contributor

h-a-n-a commented Apr 22, 2024

Thank you

@h-a-n-a h-a-n-a enabled auto-merge (squash) April 22, 2024 05:02
@h-a-n-a h-a-n-a merged commit e419925 into web-infra-dev:main Apr 22, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants