fix: get correct parent module for root module of concatenated module #7212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #7170
parent_module_by_dependency_id
is usingconnection.original_module_identifier
to find the parent module, but connection will be update by concatenated module, the parent of a module will be updated from the root module of the concatenated module to the concatenated module, which causesget_mode
returns a wrong mode, and generate wrong codeChecklist