Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get correct parent module for root module of concatenated module #7212

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

ahabhgk
Copy link
Collaborator

@ahabhgk ahabhgk commented Jul 18, 2024

Summary

fix #7170

parent_module_by_dependency_id is using connection.original_module_identifier to find the parent module, but connection will be update by concatenated module, the parent of a module will be updated from the root module of the concatenated module to the concatenated module, which causes get_mode returns a wrong mode, and generate wrong code

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit b8c7bff
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6698fd5db15ba90008ded327

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Jul 18, 2024
@ahabhgk ahabhgk enabled auto-merge (squash) July 18, 2024 11:36
@JSerFeng
Copy link
Collaborator

Also fix #7133

@ahabhgk ahabhgk merged commit 3141914 into main Jul 18, 2024
29 checks passed
@ahabhgk ahabhgk deleted the fix-get-parent-module branch July 18, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: production build with mjs empty module results in error
2 participants