Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: external module move out initial chunk #8644

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Dec 9, 2024

Summary

fix: external module move out initial chunk

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Dec 9, 2024
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 7fba250
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6756ac5d49c857000834c255

@SyMind SyMind changed the title fix: external module should move out initial chunk fix: external module move out initial chunk Dec 9, 2024
@SyMind SyMind marked this pull request as ready for review December 9, 2024 08:38
@SoonIter
Copy link
Member

SoonIter commented Dec 9, 2024

Does this issue only exist in systemjs?

@SyMind
Copy link
Member Author

SyMind commented Dec 9, 2024

@SoonIter All external modules.

@JSerFeng JSerFeng merged commit 222d040 into main Dec 10, 2024
66 checks passed
@JSerFeng JSerFeng deleted the fix-external-module branch December 10, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants