Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: chunk graph binding API #8648

Merged
merged 9 commits into from
Dec 11, 2024
Merged

refactor: chunk graph binding API #8648

merged 9 commits into from
Dec 11, 2024

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Dec 9, 2024

Summary

Refactor chunk graph binding API and support chunkGraph.getModuleChunksIterable()

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Dec 9, 2024
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit fdd4baa
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/675935686cd37c0009260ae1
😎 Deploy Preview https://deploy-preview-8648--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SyMind SyMind force-pushed the refactor-chunk-graph branch from 0db4705 to b3509cd Compare December 9, 2024 13:10
@web-infra-dev web-infra-dev deleted a comment from rspack-bot Dec 10, 2024
@SyMind
Copy link
Member Author

SyMind commented Dec 10, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Dec 10, 2024

📝 Benchmark detail: Open

Name Base (2024-12-10 222d040) Current Change
10000_big_production-mode_disable-minimize + exec 36.9 s ± 120 ms 36.9 s ± 91 ms +0.01 %
10000_development-mode + exec 1.78 s ± 20 ms 1.79 s ± 18 ms +0.42 %
10000_development-mode_hmr + exec 647 ms ± 14 ms 642 ms ± 18 ms -0.81 %
10000_production-mode + exec 2.33 s ± 30 ms 2.35 s ± 22 ms +0.76 %
arco-pro_development-mode + exec 1.76 s ± 72 ms 1.74 s ± 71 ms -1.40 %
arco-pro_development-mode_hmr + exec 424 ms ± 3.7 ms 425 ms ± 1.3 ms +0.18 %
arco-pro_production-mode + exec 3.12 s ± 83 ms 3.1 s ± 48 ms -0.60 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.15 s ± 67 ms 3.15 s ± 58 ms -0.14 %
threejs_development-mode_10x + exec 1.61 s ± 17 ms 1.62 s ± 21 ms +0.19 %
threejs_development-mode_10x_hmr + exec 787 ms ± 15 ms 790 ms ± 8.7 ms +0.30 %
threejs_production-mode_10x + exec 4.87 s ± 42 ms 4.9 s ± 35 ms +0.63 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.16 s ± 75 ms 3.15 s ± 93 ms -0.24 %
10000_big_production-mode_disable-minimize + rss memory 9801 MiB ± 45.3 MiB 9793 MiB ± 35.2 MiB -0.08 %
10000_development-mode + rss memory 814 MiB ± 15.8 MiB 827 MiB ± 28.1 MiB +1.67 %
10000_development-mode_hmr + rss memory 1931 MiB ± 377 MiB 1997 MiB ± 207 MiB +3.39 %
10000_production-mode + rss memory 694 MiB ± 34.6 MiB 722 MiB ± 47.6 MiB +4.16 %
arco-pro_development-mode + rss memory 712 MiB ± 43.5 MiB 713 MiB ± 32.6 MiB +0.16 %
arco-pro_development-mode_hmr + rss memory 914 MiB ± 82.9 MiB 921 MiB ± 90 MiB +0.72 %
arco-pro_production-mode + rss memory 825 MiB ± 49 MiB 823 MiB ± 62.6 MiB -0.29 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 827 MiB ± 66.8 MiB 802 MiB ± 52.7 MiB -3.01 %
threejs_development-mode_10x + rss memory 771 MiB ± 62.4 MiB 778 MiB ± 39 MiB +0.87 %
threejs_development-mode_10x_hmr + rss memory 1644 MiB ± 353 MiB 1728 MiB ± 136 MiB +5.07 %
threejs_production-mode_10x + rss memory 1122 MiB ± 48 MiB 1092 MiB ± 73.3 MiB -2.68 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 811 MiB ± 45.8 MiB 798 MiB ± 56 MiB -1.52 %

@JSerFeng JSerFeng changed the title refactor: chunk graph refactor: refactor chunk graph binding API Dec 10, 2024
@SyMind SyMind changed the title refactor: refactor chunk graph binding API refactor: chunk graph binding API Dec 10, 2024
@SyMind SyMind marked this pull request as ready for review December 11, 2024 06:52
@SyMind SyMind merged commit 532a15d into main Dec 11, 2024
33 checks passed
@SyMind SyMind deleted the refactor-chunk-graph branch December 11, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants