Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct type for loaderContext.importModule #8766

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

chenjiahan
Copy link
Member

Summary

Align the loaderContext.importModule() type definition with webpack and add generics to specify the type of export.

Ref: https://github.com/webpack/webpack/blob/964c0315df0ee86a2b4edfdf621afa19db140d4f/declarations/LoaderContext.d.ts#L90-L95

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Dec 18, 2024
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit e4b9627
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6762d8b1531f150008b658a2

@chenjiahan chenjiahan requested a review from JSerFeng December 18, 2024 14:15
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 67c1855
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6762d8c4e6ad590008e76f72

@LingyuCoder LingyuCoder merged commit 7099641 into main Dec 20, 2024
31 checks passed
@LingyuCoder LingyuCoder deleted the import_module_1218 branch December 20, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants