Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rspack cssParser will parse failed when url(' ') #8822

Closed
wants to merge 1 commit into from

Conversation

cbbfcd
Copy link
Contributor

@cbbfcd cbbfcd commented Dec 23, 2024

Summary

fix 8788

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


bobihuang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Dec 23, 2024
Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 190e399
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/676988b7c4ae310008ca5785
😎 Deploy Preview https://deploy-preview-8822--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cbbfcd cbbfcd changed the title fix: parsing process for handling strings with multiple spaces fix: Rspack cssParser will parse failed when url(' ') Dec 23, 2024
Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #8822 will not alter performance

Comparing cbbfcd:fix/empty-url (190e399) with main (a4aa3a9)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

@cbbfcd cbbfcd closed this Dec 23, 2024
@cbbfcd cbbfcd deleted the fix/empty-url branch December 23, 2024 17:13
@cbbfcd
Copy link
Contributor Author

cbbfcd commented Dec 23, 2024

CLA problem, i will re-pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Rspack cssParser will parse failed when url(' ')
2 participants