Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Rspack cssParser will parse failed when url(' ') #8824

Merged
merged 1 commit into from
Dec 24, 2024
Merged

fix: Rspack cssParser will parse failed when url(' ') #8824

merged 1 commit into from
Dec 24, 2024
+12 −1

Conversation

cbbfcd
Copy link
Contributor

@cbbfcd cbbfcd commented Dec 23, 2024

fix issue 8788

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Dec 23, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 23, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit da7685e
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6769990c5a64ae0008926a64
😎 Deploy Preview https://deploy-preview-8824--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #8824 will not alter performance

Comparing cbbfcd:fix/css-parser-empty-url (da7685e) with main (a4aa3a9)

Summary

✅ 3 untouched benchmarks

ahabhgk
ahabhgk approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@GiveMe-A-Name GiveMe-A-Name merged commit 7607a4e into web-infra-dev:main Dec 24, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiveMe-A-Name GiveMe-A-Name GiveMe-A-Name approved these changes

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Rspack cssParser will parse failed when url(' ')
3 participants
@cbbfcd @ahabhgk @GiveMe-A-Name