fix: importModule should receive error correctly #8827
Merged
+142
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release: bug fix
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
JSerFeng
force-pushed
the
fix/importModule
branch
from
57119b1 to
e94a58e
Compare
CodSpeed Performance ReportMerging #8827 will not alter performanceComparing Summary
|
JSerFeng
force-pushed
the
fix/importModule
branch
2 times, most recently
from
3dacd81 to
a462913
Compare
JSerFeng
force-pushed
the
fix/importModule
branch
from
a462913 to
39eb8ba
Compare
ahabhgk
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
importModule should receive error from rust correctly
Checklist