New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(modern-module): jump the asset entry module concaten for Rslib #8835

Closed

SoonIter wants to merge 1 commit into web-infra-dev:main from SoonIter:modern-module

+12 −1

Member

SoonIter commented Dec 24, 2024 •

edited

Loading

Summary

when set library.type = "modern-module" and set asset as entry, there are several bugs

not emit asset
url is missing

Checklist

Tests updated (or not required).
Documentation updated (or not required).


          chore: update

e363622

netlify bot commented Dec 24, 2024 •

edited

Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`e363622`
🔍 Latest deploy log	https://app.netlify.com/sites/rspack/deploys/676a8c6efee0e80008e88f53

Member Author

SoonIter commented Dec 24, 2024

this is a pr from forked SoonIter/rspack... I cannot create canary release

SoonIter closed this

codspeed-hq bot commented Dec 24, 2024

CodSpeed Performance Report

Merging #8835 will not alter performance

_{Comparing SoonIter:modern-module (e363622) with main (d400cd1)}

Summary

✅ 3 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet