Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wptrunner] Should browsers always be force-stopped? #48066

Open
jonathan-j-lee opened this issue Sep 10, 2024 · 0 comments
Open

[wptrunner] Should browsers always be force-stopped? #48066

jonathan-j-lee opened this issue Sep 10, 2024 · 0 comments
Labels
infra wptrunner The automated test runner, commonly called through ./wpt run

Comments

@jonathan-j-lee
Copy link
Contributor

jonathan-j-lee commented Sep 10, 2024

Currently, each TestRunnerManager thread essentially uses this code to stop the browser:

def stop_runner(self, force=False):
    self.browser.stop(force=force)
    ...
    self.browser.stop(force=True)

Most browsers implement stop(force=True) as following up SIGTERM with SIGKILL if the browser doesn't shut down gracefully. #19188 added the stop(force=True) call, which seems to make the first one entirely redundant?

I think the motivation of #19188 still stands (i.e., never leak processes), so maybe wptrunner should stop supporting stop(force=False) (also, clean up the testrunner plumbing).

CC @jgraham @gsnedders

@jonathan-j-lee jonathan-j-lee added infra wptrunner The automated test runner, commonly called through ./wpt run labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

No branches or pull requests

1 participant