You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Most browsers implement stop(force=True) as following up SIGTERM with SIGKILL if the browser doesn't shut down gracefully. #19188 added the stop(force=True) call, which seems to make the first one entirely redundant?
I think the motivation of #19188 still stands (i.e., never leak processes), so maybe wptrunner should stop supporting stop(force=False) (also, clean up the testrunner plumbing).
Currently, each
TestRunnerManager
thread essentially uses this code to stop the browser:Most browsers implement
stop(force=True)
as following up SIGTERM with SIGKILL if the browser doesn't shut down gracefully. #19188 added thestop(force=True)
call, which seems to make the first one entirely redundant?I think the motivation of #19188 still stands (i.e., never leak processes), so maybe wptrunner should stop supporting
stop(force=False)
(also, clean up the testrunner plumbing).CC @jgraham @gsnedders
The text was updated successfully, but these errors were encountered: