[wptrunner] Stop the runner process before the browser #48030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `stop` state will `ensure_runner_stopped` soon after `runner_teardown` anyway via `TestRunnerManager._cleanup_run_loop()`.
This could occur if `testrunner.TestRunner` encounters an error early.
... via a `stop` message that tells the runner to gracefully tear down the protocol. * For WebDriver-based executors, this will close the session appropriately [1]. * For `chromedriver` in particular, this will ensure some per-session `/tmp/.org.chromium.Chromium.*` temporary directories [2], which are currently leaked, are deleted. Also, remove `browser.stop(force=True)` so that the `force_stop` setting of the `stop` state is actually respected. (This really only makes a difference for browser processes on POSIX platforms that don't respond to SIGTERM, which are probably worth investigation anyway.) [1]: https://www.w3.org/TR/webdriver/#delete-session [2]: https://source.chromium.org/chromium/chromium/src/+/main:chrome/test/chromedriver/chrome/chrome_desktop_impl.cc;l=107-122;drc=b14c93608871784e41d6d40f1c5952cf24aa39db;bpv=0;bpt=0
wpt-pr-bot
added
infra
wptrunner
WeizhongX
reviewed
Sep 9, 2024
WeizhongX
reviewed
Sep 9, 2024
WeizhongX
reviewed
Sep 9, 2024
WeizhongX
approved these changes
Sep 10, 2024
jonathan-j-lee
merged commit d65cf80
into
web-platform-tests:master
31 of 33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... via a
stopmessage that tells the runner to gracefully tear downthe protocol.
appropriately.
chromedriverin particular, this will ensure some per-session/tmp/.org.chromium.Chromium.*temporary directories, which arecurrently leaked, are deleted.