Add a test for fullscreen for the A/B/A case #39828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 3, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4501251
branch
from
ebc90b1
to
64a5825
Compare
4 tasks
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4501251
branch
from
64a5825
to
5c64599
Compare
4 tasks
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4501251
branch
from
5c64599
to
73c50f9
Compare
See the discussion at [1] for more context. This test requests fullscreen on A, then B, then A, where A and B are sibling divs. All three requests should succeed, and at the end, A should be topmost (and the fullscreen element) with both A and B in the top layer. [1] whatwg/fullscreen#223 Change-Id: I3f35dda5b9eb1bc24201616bb5bb4949d20fd170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4501251 Commit-Queue: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1141456}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4501251
branch
from
73c50f9
to
b0d4851
Compare
annevk
pushed a commit
to whatwg/html
that referenced
this pull request
Jun 21, 2023
This change moves the top layer references from Fullscreen to CSS and uses the new algorithms to add and remove from the top layer. Moving the top layer concept to CSS has been discussed in these issues: * w3c/csswg-drafts#4998 * w3c/csswg-drafts#6939 * w3c/csswg-drafts#7845 * w3c/csswg-drafts#8240 Tests: web-platform-tests/wpt#39828.
rubberyuzu
pushed a commit
to rubberyuzu/html
that referenced
this pull request
Jul 20, 2023
This change moves the top layer references from Fullscreen to CSS and uses the new algorithms to add and remove from the top layer. Moving the top layer concept to CSS has been discussed in these issues: * w3c/csswg-drafts#4998 * w3c/csswg-drafts#6939 * w3c/csswg-drafts#7845 * w3c/csswg-drafts#8240 Tests: web-platform-tests/wpt#39828.
rubberyuzu
pushed a commit
to rubberyuzu/html
that referenced
this pull request
Jul 21, 2023
This change moves the top layer references from Fullscreen to CSS and uses the new algorithms to add and remove from the top layer. Moving the top layer concept to CSS has been discussed in these issues: * w3c/csswg-drafts#4998 * w3c/csswg-drafts#6939 * w3c/csswg-drafts#7845 * w3c/csswg-drafts#8240 Tests: web-platform-tests/wpt#39828.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion at [1] for more context. This test requests
fullscreen on A, then B, then A, where A and B are sibling divs. All
three requests should succeed, and at the end, A should be topmost (and
the fullscreen element) with both A and B in the top layer.
[1] whatwg/fullscreen#223
Change-Id: I3f35dda5b9eb1bc24201616bb5bb4949d20fd170
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4501251
Commit-Queue: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1141456}