Add support for the shadow root clonable flag #44216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5239277
branch
10 times, most recently
from
46e59f4
to
090bf44
Compare
This landed in the these two spec PRs: whatwg/dom#892 whatwg/dom#1237 and was discussed here: whatwg/dom#1137 whatwg/dom#1236 This CL adds support for clonable, behind a new ShadowRootClonable flag. There was already a very basic test, but I added a few more cases. This should be fairly web compatible, but there is a risk since with this feature enabled, declarative shadow roots in the main document (as opposed to in a <template> element) will now be cloned. I will launch this feature carefully. Safari has already shipped, and Gecko has implemented this and plans to ship soon. Chromestatus: https://chromestatus.com/feature/5161435196030976 I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/nZhPt0ePCAA Bug: 1510466 Change-Id: Ie25b72f369ca0542555f91010b0f22d295403728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5239277 Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1253059}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5239277
branch
from
090bf44
to
3dfd71d
Compare
wpt-pr-bot
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This landed in the these two spec PRs:
whatwg/dom#892
whatwg/dom#1237
and was discussed here:
whatwg/dom#1137
whatwg/dom#1236
This CL adds support for clonable, behind a new ShadowRootClonable
flag. There was already a very basic test, but I added a few
more cases.
This should be fairly web compatible, but there is a risk since with
this feature enabled, declarative shadow roots in the main document
(as opposed to in a <template> element) will now be cloned. I will
launch this feature carefully. Safari has already shipped, and Gecko
has implemented this and plans to ship soon.
Chromestatus:
https://chromestatus.com/feature/5161435196030976
I2P:
https://groups.google.com/a/chromium.org/g/blink-dev/c/nZhPt0ePCAA
Bug: 1510466
Change-Id: Ie25b72f369ca0542555f91010b0f22d295403728
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5239277
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1253059}