Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPT: Script child removal does not trigger execution #45085

Merged
merged 1 commit into from
Mar 13, 2024

Commits on Mar 13, 2024

  1. WPT: Script child removal does not trigger execution

    Given the old Chromium change that introduced this behavior:
     - https://source.chromium.org/chromium/chromium/src/+/604e798ec6ee30f44d57a5c4a44ce3dab3a871ed
    
    ... the old discussion in:
     - whatwg/dom#732 (review)
     - whatwg/html#4354 (comment)
    
    ... and the much newer discussion in:
     - whatwg/dom#1261
     - whatwg/html#10188
    
    This CL upstreams an old test ensuring that removal of a child node
    from a script node that has not "already started" [1], does not trigger
    script execution. Only the *insertion* of child nodes (to a
    non-already-started script node) should trigger that script's execution.
    
    [1]: https://html.spec.whatwg.org/C#already-started
    
    R=nrosenthal@chromium.org
    
    Bug: 40150299
    Change-Id: I750ccee0a2be834360c557042e975547c8ddd32c
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5367238
    Reviewed-by: Noam Rosenthal <nrosenthal@chromium.org>
    Commit-Queue: Dominic Farolino <dom@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1272330}
    domfarolino authored and chromium-wpt-export-bot committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    068394c View commit details
    Browse the repository at this point in the history