Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, you might want to see https://github.com/web-platform-tests/wpt/blob/master/dom/nodes/insertion-removing-steps/Node-appendChild-script-in-script.tentative.html. It's related to whatwg/dom#1261 and whatwg/html#10188, and once the latter lands, I think we'll need a different set of expectations corresponding with the simpler spec.
In fact, I'm wondering if we don't even need the test in this PR once we make the existing one I linked to above, non-tentative. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one you linked to is basically the same as 128, right, in that it relies on the parser-inserted script s1 being unflagged as parser-inserted? So I think this variant still has some small but nonzero value compared to either of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that may well address the point about whether we should remove this test or not. But I still think it could be good to update the expectations to match what we're pursuing in HTML regarding script scheduling + children changed events.