fix: cacheControlOverride not being overridden correctly (#9)

.changeset/lucky-hats-flow.md

@@ -0,0 +1,5 @@
+---
+"@web-widget/shared-cache": patch
+---
+
+Fix `cacheControlOverride` not being overridden correctly.

package.json

@@ -83,5 +83,8 @@
       }
     }
   },
-  "type": "module"
+  "type": "module",
+  "files": [
+    "dist"
+  ]
 }

src/fetch.test.ts

@@ -45,6 +45,7 @@ describe('override headers', () => {
     });
 
     expect(res.headers.get('cache-control')).toBe('max-age=300, s-maxage=120');
+    expect(res.headers.get('x-cache-status')).toBe(MISS);
   });
 
   test('the `vary` header should be overridable', async () => {
@@ -55,6 +56,7 @@ describe('override headers', () => {
         return new Response('lol', {
           headers: {
             vary: 'x-custom',
+            'cache-control': 'max-age=300',
           },
         });
       },
@@ -66,6 +68,7 @@ describe('override headers', () => {
     });
 
     expect(res.headers.get('vary')).toBe('x-custom, accept-language');
+    expect(res.headers.get('x-cache-status')).toBe(MISS);
   });
 
   test('do not set HTTP headers when status code is greater than or equal to 500', async () => {
@@ -87,6 +90,7 @@ describe('override headers', () => {
 
     expect(res.headers.get('cache-control')).toBe(null);
     expect(res.headers.get('vary')).toBe(null);
+    expect(res.headers.get('x-cache-status')).toBe(DYNAMIC);
   });
 });
 

src/fetch.ts

@@ -64,8 +64,8 @@ export function createSharedCacheFetch(
     }
 
     const fetchedResponse = await fetcher(request);
-    const cacheControl = fetchedResponse.headers.get('cache-control');
     setCacheControlAndVary(fetchedResponse, sharedCache);
+    const cacheControl = fetchedResponse.headers.get('cache-control');
 
     if (cacheControl) {
       if (bypassCache(cacheControl)) {