Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release-please for db #1577

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: release-please for db #1577

wants to merge 1 commit into from

Conversation

olizilla
Copy link
Contributor

@olizilla olizilla commented Jun 27, 2022

this is a nudge to implement the db migration automation.

as is, this will add release please notes to the PRs and increment the package number.

If we do a major change, we'd need to bump the db dep number in the other projects.

TODO:

  • bring back release-please for db
  • fork prod db to staging on merge to main
  • auto apply migrations to staging
  • snapshot prod db on release
  • auto apply migrations to prod

see: #1482
see: #1275

License: (Apache-2.0 AND MIT)
Signed-off-by: Oli Evans oli@tableflip.io

this is a nudge to finish off the db migration automation.

as is, this will add release please notes to the PRs and increment the package number.

If we do a major change, we'd need to bump the db dep number in the other projects.

TODO:
- [ ] fork prod db to staging on merge to main
- [ ] auto apply migrations to staging
- [ ] snapshot prod db on release
- [ ] auto apply migrations to prod

see: #1482
see: #1275

License: (Apache-2.0 AND MIT)
Signed-off-by: Oli Evans <oli@tableflip.io>
@olizilla
Copy link
Contributor Author

@vasco-santos should we merge this as is just to get release notes and package.json versioning for the db project? api and cron would have to update their dep version in their package.json if there was a major revision, and could elect to bump it deliberately when they want to trigger a release for a db change.

@vasco-santos
Copy link
Contributor

@vasco-santos should we merge this as is just to get release notes and package.json versioning for the db project?

Yes! we should do this in multiple steps

# ./packages/w3/bin.js put ./upload-test-small --api https://api-staging.web3.storage --token ${{ secrets.STAGING_WEB3_TOKEN }}

release:
name: Release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we check for if: github.event_name == 'push' && github.ref == 'refs/heads/main' like commented above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants